-
Notifications
You must be signed in to change notification settings - Fork 669
Draft: Archiving blog post #4928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying eventstore with
|
| Latest commit: |
b391187
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62a581d3.eventstore.pages.dev |
| Branch Preview URL: | https://archiving-blog-post.eventstore.pages.dev |
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
| - How do I determine proper values for the retention policy? | ||
| - How do I scavenge the archive? | ||
| - How do backups work? | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a part 2 blog post that goes into these details? I understand that they are in the documentation, but this may be useful content to also surface in another blog post as well.
* Update archiving_blog_post.md Shaan - I was looking through PRs and came across this blog. Nice work. I quickly read through it and offer some grammatical cleanup. This review wasn't on my radar (or yours) - so don't feel obliged to merge into your branch if you don't wish. * Accept Shaan's preferences --------- Co-authored-by: Shaan Nobee <sniper111@gmail.com>
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2024.3.4
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
timothycoleman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, picture suggestion above and suggestions inline.
Two other suggestions
- somewhere we ought to have a sentence about the key point: the archiver node uploads all committed completed chunks to the archive regardless of retention policy. the retention policy governs which data the nodes discard locally.
- there are various limitations documented in the main doc, it would be good to draw some attention to them, maybe not individually but just that there are some. Perhaps at the top we can refer to this as the 'First version' of archiving or something like that with mention of the existence of limitations
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
3857cca to
ef96e9e
Compare
ef96e9e to
b391187
Compare
|
great thanks @shaan1337 this looks good to me |
|
now published https://www.kurrent.io/blog/archive-feature-explained/ |



No description provided.