Skip to content

Conversation

@shaan1337
Copy link
Member

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 21, 2025

Deploying eventstore with  Cloudflare Pages  Cloudflare Pages

Latest commit: b391187
Status: ✅  Deploy successful!
Preview URL: https://62a581d3.eventstore.pages.dev
Branch Preview URL: https://archiving-blog-post.eventstore.pages.dev

View logs

@github-actions
Copy link
Contributor

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

- How do I determine proper values for the retention policy?
- How do I scavenge the archive?
- How do backups work?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a part 2 blog post that goes into these details? I understand that they are in the documentation, but this may be useful content to also surface in another blog post as well.

@timothycoleman
Copy link
Contributor

image

perhaps something like this as a picture

* Update archiving_blog_post.md

Shaan - I was looking through PRs and came across this blog.  Nice work.  I quickly read through it and offer some grammatical cleanup.  This review wasn't on my radar (or yours) - so don't feel obliged to merge into your branch if you don't wish.

* Accept Shaan's preferences

---------

Co-authored-by: Shaan Nobee <sniper111@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.3.4
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Contributor

@timothycoleman timothycoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, picture suggestion above and suggestions inline.

Two other suggestions

  1. somewhere we ought to have a sentence about the key point: the archiver node uploads all committed completed chunks to the archive regardless of retention policy. the retention policy governs which data the nodes discard locally.
  2. there are various limitations documented in the main doc, it would be good to draw some attention to them, maybe not individually but just that there are some. Perhaps at the top we can refer to this as the 'First version' of archiving or something like that with mention of the existence of limitations

shaan1337 and others added 6 commits April 23, 2025 15:09
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
Co-authored-by: Tim Coleman <timothy.coleman@gmail.com>
@shaan1337
Copy link
Member Author

perhaps something like this as a picture

image

thanks! I redrew it with excalidraw to give a more friendly touch

archiving

@shaan1337 shaan1337 force-pushed the archiving-blog-post branch 2 times, most recently from 3857cca to ef96e9e Compare April 25, 2025 10:36
@shaan1337 shaan1337 force-pushed the archiving-blog-post branch from ef96e9e to b391187 Compare April 25, 2025 10:48
@timothycoleman
Copy link
Contributor

great thanks @shaan1337 this looks good to me

@timothycoleman
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants