fixed bug about displaying cylinder base #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
円柱の面が正しく表示されないバグがあったのでそれを修正した
バグの原因
修正内容
テスト
以下のケースで正しく描画されるようになった
ちなみに、修正前の状態では、円柱の底面が正しく描画されないとき、円柱の法線ベクトルを逆向きにすることで正しく表示されるようになっていた。そのため、他のケースで円柱の底面が正しく描画されているとき、法線ベクトルを逆向きにしても正しく描画できるかを確認して欲しい。