Remove unimplemented flag 'never'

kurtosis-tech · Oct 19, 2023 · 24124f2 · 24124f2
1 parent eee5e3d
commit 24124f2
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 32 deletions.
diff --git a/api/golang/engine/kurtosis_engine_rpc_api_bindings/engine_service.pb.go b/api/golang/engine/kurtosis_engine_rpc_api_bindings/engine_service.pb.go
diff --git a/cli/cli/command_args/run/image_download.go b/cli/cli/command_args/run/image_download.go
@@ -4,7 +4,6 @@ package run
 type ImageDownload int
 
 const (
-	never ImageDownload = iota
-	always
+	always ImageDownload = iota
 	missing
 )
diff --git a/cli/cli/command_args/run/imagedownload_enumer.go b/cli/cli/command_args/run/imagedownload_enumer.go
diff --git a/cli/cli/commands/run/run.go b/cli/cli/commands/run/run.go
@@ -196,7 +196,7 @@ var StarlarkRunCmd = &engine_consuming_kurtosis_command.EngineConsumingKurtosisC
 		},
 		{
 			Key:     imageDownloadFlagKey,
-			Usage:   "If unset, it defaults to `missing` for fetching the latest image only if not available in local cache. Use `never` to only use local cached image (never fetch new images) and `always` to always fetch the latest image.",
+			Usage:   "If unset, it defaults to `missing` for fetching the latest image only if not available in local cache. Use `always` to always fetch the latest image.",
 			Type:    flags.FlagType_String,
 			Default: defaultImageDownload,
 		},

diff --git a/...ner-engine-lib/lib/backend_impls/docker/docker_manager/create_and_start_container_args.go b/...ner-engine-lib/lib/backend_impls/docker/docker_manager/create_and_start_container_args.go
@@ -261,11 +261,6 @@ func (builder *CreateAndStartContainerArgsBuilder) WithPullingLatestImageAlways(
 	return builder
 }
 
-func (builder *CreateAndStartContainerArgsBuilder) WithPullingLatestImageNever() *CreateAndStartContainerArgsBuilder {
-	builder.imageDownloadMode = image_download_mode.Never
-	return builder
-}
-
 func (builder *CreateAndStartContainerArgsBuilder) WithPullingLatestImageOnMissing() *CreateAndStartContainerArgsBuilder {
 	builder.imageDownloadMode = image_download_mode.Missing
 	return builder

diff --git a/container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go b/container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go
@@ -1257,7 +1257,7 @@ func (manager *DockerManager) FetchImage(ctx context.Context, image string, down
 		err = manager.FetchLatestImage(ctx, image)
 	case image_download_mode.Missing:
 		pulledFromRemote, err = manager.FetchImageMissing(ctx, image)
-	case image_download_mode.Never:
+	default:
 		return false, stacktrace.NewError("Undefined image pulling mode: '%v'", image_pulling)
 	}
 

diff --git a/...ainer-engine-lib/lib/backend_interface/objects/image_download_mode/image_download_mode.go b/...ainer-engine-lib/lib/backend_interface/objects/image_download_mode/image_download_mode.go
@@ -8,17 +8,14 @@ package image_download_mode
 import "github.com/kurtosis-tech/kurtosis/api/golang/core/kurtosis_core_rpc_api_bindings"
 
 const (
-	Never   ImageDownloadMode = "never"
-	Always                    = "always"
-	Missing                   = "missing"
+	Always  = "always"
+	Missing = "missing"
 )
 
 type ImageDownloadMode string
 
 func FromAPI(api_mode kurtosis_core_rpc_api_bindings.ImageDownloadMode) ImageDownloadMode {
 	switch kurtosis_core_rpc_api_bindings.ImageDownloadMode_name[int32(api_mode)] {
-	case "never":
-		return Never
 	case "always":
 		return Always
 	case "missing":