Skip to content

Commit

Permalink
fix: actually create production enclaves (#1682)
Browse files Browse the repository at this point in the history
## Description:
Piotr from Nethermind reported that production mode wasn't doing
anything. Here's a fix.

Tested using

```
def run(plan):
    plan.add_service(
        name = "test-service",
        config = ServiceConfig(
            image = "alpine:3.17",
            cmd = ["/bin/sh", "-c", "sleep 30 && exit 1"]
        )
    )
```
  • Loading branch information
h4ck3rk3y authored Nov 3, 2023
1 parent fdeed72 commit 8987212
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion api/golang/engine/lib/kurtosis_context/kurtosis_context.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func (kurtosisCtx *KurtosisContext) CreateProductionEnclave(
enclaveName string,
) (*enclaves.EnclaveContext, error) {

createEnclaveArgs := newCreateEnclaveArgsWithDefaultValues(enclaveName)
createEnclaveArgs := newCreateProductionEnclaveWithDefaultValues(enclaveName)

response, err := kurtosisCtx.engineClient.CreateEnclave(ctx, createEnclaveArgs)
if err != nil {
Expand Down Expand Up @@ -604,3 +604,19 @@ func newCreateEnclaveArgsWithDefaultValues(enclaveName string) *kurtosis_engine_

return createEnclaveArgs
}

func newCreateProductionEnclaveWithDefaultValues(enclaveName string) *kurtosis_engine_rpc_api_bindings.CreateEnclaveArgs {

defaultApiContainerVersionTag := defaultApiContainerVersionTagStr
defaultApiContainerLogLevel := defaultApiContainerLogLevelStr
defaultEnclaveMode := kurtosis_engine_rpc_api_bindings.EnclaveMode_PRODUCTION

createEnclaveArgs := &kurtosis_engine_rpc_api_bindings.CreateEnclaveArgs{
EnclaveName: &enclaveName,
ApiContainerVersionTag: &defaultApiContainerVersionTag,
ApiContainerLogLevel: &defaultApiContainerLogLevel,
Mode: &defaultEnclaveMode,
}

return createEnclaveArgs
}

0 comments on commit 8987212

Please sign in to comment.