Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return if enclave is in production mode on enclave inspect #1363

Closed
victorcolombo opened this issue Sep 21, 2023 · 3 comments · Fixed by #1751 or #1770
Closed

Return if enclave is in production mode on enclave inspect #1363

victorcolombo opened this issue Sep 21, 2023 · 3 comments · Fixed by #1751 or #1770
Assignees
Labels

Comments

@victorcolombo
Copy link
Contributor

Background & motivation

Right now, the only viable way to know if an enclave is on production mode is by inspecting the serialized env variables. This makes it very hard to keep track what would be the behavior of this enclave if a service were to go down (especially when the enclave is long running and you forget the mode)

Desired behaviour

Return the isProduction field in CLI, web

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

@victorcolombo
Copy link
Contributor Author

Current workaround:

docker container ls | grep kurtosistech/core (get container id, in this example, 9a9c03eb321f)
docker container inspect 9a9c03eb321f | grep isProduction

Returns

...isProductionEnclave\":true}"

@leeederek
Copy link
Contributor

Thanks for filing @victorcolombo - this seems like low-hanging fruit usability feature.

@mieubrisse
Copy link
Collaborator

mieubrisse commented Sep 26, 2023

Design: the current enclave inspect header looks like this:

Name:            icy-hill
UUID:            0a3065d658b0
Status:          RUNNING
Creation Time:   Tue, 26 Sep 2023 13:15:16 -03

I'd like to add a Flags section like so:

Name:            icy-hill
UUID:            0a3065d658b0
Status:          RUNNING
Creation Time:   Tue, 26 Sep 2023 13:15:16 -03
Flags:            production

The only value will be production for now, but as we add more enclave flags we'll add those here

IMPL NOTES:

@leoporoli leoporoli self-assigned this Nov 8, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2023
…command (#1751)

## Description:
add enclave's flags info in the `kurtosis enclave inspect` CLI command

## Is this change user facing?
YES

## References (if applicable):
Fix #1363
github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.85.19](0.85.18...0.85.19)
(2023-11-13)


### Features

* add enclave's flags info in the `kurtosis enclave inspect` CLI command
([#1751](#1751))
([35bad59](35bad59)),
closes [#1363](#1363)


### Bug Fixes

* emui optimistic data loading
([#1771](#1771))
([f105fa0](f105fa0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants