-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: manage parameters and URL #1689
Conversation
# Conflicts: # enclave-manager/web/src/components/enclaves/modals/ConfigureEnclaveModal.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main points:
- please check prettier - if you want to change the rules could you also commit them. Consistent code formatters reduces noise in code review.
- Given you've gone part way to adding the build change could you also .gitignore the engine output?
enclave-manager/web/src/client/enclaveManager/KurtosisClient.ts
Outdated
Show resolved
Hide resolved
enclave-manager/web/src/components/enclaves/configuration/EnclaveConfigurationForm.tsx
Outdated
Show resolved
Hide resolved
enclave-manager/web/src/client/enclaveManager/KurtosisClientContext.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think prettier:fix also needs to be run over this change.
done - and added curly |
## Description: This change adds support for showing enclave service logs in the new enclave manager ui. Additionally, this pr contains a partial implementation of the service view ui - full implementation to follow. ### Demo: In this demo `github.com/kurtosis-tech/log-load-package` is used to demonstrate large quantities of logs don't seem to break following. Additionally, my browser has it's locale set to san francisco - so that browser locale dependent timestamps can be demonstrated. https://github.com/kurtosis-tech/kurtosis/assets/4419574/533b5f5a-7fdf-40b1-a6c5-e0b67970811c ## Is this change user facing? YES
🤖 I have created a release *beep* *boop* --- ## [0.85.4](0.85.3...0.85.4) (2023-11-07) ### Features * add autocomplete for cluster set command ([#1695](#1695)) ([d36164d](d36164d)) * manage parameters and URL ([#1689](#1689)) ([eafc056](eafc056)) * new em ui enclave logs ([#1696](#1696)) ([788c7bc](788c7bc)) * print Made with Kurtosis at the end of a run ([#1687](#1687)) ([a08b0b1](a08b0b1)) ### Bug Fixes * correct is_ci value in metrics from APIC ([#1697](#1697)) ([9df62dd](9df62dd)) * kurtosis run considers every nonexistent path to be a URL and fails with a suspicious error ([#1706](#1706)) ([0f7809e](0f7809e)), closes [#1705](#1705) * return the correct yaml parsing error ([#1691](#1691)) ([c6170ec](c6170ec)) * user/instance id values were flipped ([#1698](#1698)) ([901069c](901069c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Description:
Changes:
Is this change user facing?
YES