fix: correct is_ci value in metrics from APIC #1697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Earlier metrics from the APIC wouldn't get the right value for is_ci as they would look for the CI environment(TF_BUILD, CIRCLE_CI...) variables which our docker container wouldn't contain;
Now
So if someone is running in Circle/GitHub actions - wherever the
kurtosis engine restart
happens we get the valid IS_CI value for that CLI