Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: Print the out-of-date Kurtosis version WARN message once per hour #169

Closed
mieubrisse opened this issue Mar 14, 2023 · 0 comments · Fixed by #224
Closed

[FR]: Print the out-of-date Kurtosis version WARN message once per hour #169

mieubrisse opened this issue Mar 14, 2023 · 0 comments · Fixed by #224
Assignees
@h4ck3rk3y
Labels
feature request

Comments

@mieubrisse
Copy link
Collaborator

Background and motivation

This error message is really, really annoying. It actually does force me to upgrade though, so it's very good for what we want it - just would like this to be less annoying (and the Waku folks agree).

Current behavior

The pester happens on every kurtosis CLI run

Desired behavior

The pester happens maximum once per hour.

(Impl note: we can easily accomplish this by dropping a file with the last pester time in the "data" directory of XDG. Use the codepath for the CLI actually determining what the latest version is as an example. @leoporoli built this and it works very well).

How important is this feature or improvement to you?

Painful, the lack of this feature makes using Kurtosis frictionful.
@h4ck3rk3y h4ck3rk3y self-assigned this Mar 14, 2023
@h4ck3rk3y h4ck3rk3y mentioned this issue Mar 15, 2023
Merged
2 tasks
@h4ck3rk3y h4ck3rk3y linked a pull request Mar 15, 2023 that will close this issue
fix: print the upgrade CLI warning at most hourly #224
Merged
2 tasks
h4ck3rk3y added a commit that referenced this issue Mar 16, 2023
@h4ck3rk3y
fix: print the upgrade CLI warning at most hourly (#224)
f40ee90 
## Description:
We would check for versions on everyrun and warn users if they are on an
old version. We only do that hourly now.

## Is this change user facing?
<!-- A user facing change is one that you should expect a day-to-day
user to encounter or if the change requires user-action upon or before
upgrading. If in doubt, select "Yes" -->
* [x] Yes
* [ ] No

<!-- If yes, please add the  label to this Pull Request -->

## References (if applicable):
#169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h4ck3rk3y h4ck3rk3y

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: print the upgrade CLI warning at most hourly kurtosis-tech/kurtosis
2 participants
@mieubrisse @h4ck3rk3y