feat: support downloading artifacts in the new emui #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
reviewed
Nov 8, 2023
enclave-manager/web/src/components/enclaves/widgets/DownloadFileButton.tsx
Show resolved
Hide resolved
## Description: This PR implements all burdown feedback for: * Enclave list view (make clickable cells work properly, make headers highlightable when sortable, image names clickable, make non clickable styles work with correct styling) * Enclave overview (remove source tab, fix cell interactivity in table for ports, merge public private ports in popover, drop ports timeout) * Enclave logs (link to existing issue rather than suggesting make a new issue) * Service view (fix monaco scrolling, remove delete/edit buttons, merge public/private ports) * Enclave configuration (copy updates, but not json field update). ## Is this change user facing? YES ## References (if applicable): * https://www.notion.so/kurtosistech/FE-Devconnect-Work-breakdown-af548547e0ec4a4996f75205a4fcbd60#b9f4e5a71aad4347827473e72bc888b2
adschwartz
approved these changes
Nov 8, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.8](0.85.7...0.85.8) (2023-11-08) ### Features * support downloading artifacts in the new emui ([#1720](#1720)) ([fbfeaa3](fbfeaa3)) ### Bug Fixes * stop all services first to update the service status in the service registration during a `kurtosis enclave stop` execution ([#1712](#1712)) ([3d1e142](3d1e142)), closes [#1711](#1711) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for downloading artifacts as TGZ's from the new emui.
Additionally this PR:
Is this change user facing?
YES