Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop all services first to update the service status in the service registration during a kurtosis enclave stop execution #1712

Merged
merged 4 commits into from
Nov 8, 2023
Merged

fix: stop all services first to update the service status in the service registration during a kurtosis enclave stop execution #1712

merged 4 commits into from
Nov 8, 2023

Conversation

leoporoli
Copy link
Contributor

Description:

unregister the enclave services during a kurtosis enclave stop execution

Is this change user-facing?

NO

References (if applicable):

Fix #1711

@leoporoli leoporoli changed the title fix: unregister the enclave services during a kurtosis enclave stop execution fix: stop all services first to update the service status in the service registration during a kurtosis enclave stop execution Nov 8, 2023
h4ck3rk3y
h4ck3rk3y approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@h4ck3rk3y h4ck3rk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds alright - this puts the logic inside the CLI though; is there a world where we change StopEnclave inside engine to stop services first instead?

that way typescript/curl etc get it for free

@leoporoli leoporoli added this pull request to the merge queue Nov 8, 2023
@h4ck3rk3y h4ck3rk3y removed this pull request from the merge queue due to a manual request Nov 8, 2023
@h4ck3rk3y h4ck3rk3y added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit 3d1e142 Nov 8, 2023
37 checks passed
@h4ck3rk3y h4ck3rk3y deleted the lporoli/fix-enclave-stop-cli-cmd branch November 8, 2023 18:17
@kurtosisbot kurtosisbot mentioned this pull request Nov 8, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2023
@kurtosisbot
chore(main): release 0.85.8 (#1724)
ef79fe2 
🤖 I have created a release *beep* *boop*
---


##
[0.85.8](0.85.7...0.85.8)
(2023-11-08)


### Features

* support downloading artifacts in the new emui
([#1720](#1720))
([fbfeaa3](fbfeaa3))


### Bug Fixes

* stop all services first to update the service status in the service
registration during a `kurtosis enclave stop` execution
([#1712](#1712))
([3d1e142](3d1e142)),
closes [#1711](#1711)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h4ck3rk3y h4ck3rk3y h4ck3rk3y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The stop enclave CLI command is not updating the service status in the service registration repository
2 participants
@leoporoli @h4ck3rk3y