Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: PostHttpRequest content type should be optional, and default to application/json #183

Closed
mieubrisse opened this issue Mar 14, 2023 · 0 comments
Assignees

Comments

@mieubrisse
Copy link
Collaborator

Background and motivation

Working on quickstart; want to make an insertion; didn't see why I need to set the content type

Current behavior

User must specify

Desired behavior

Content type is optional, and defaults to application/json

How important is this feature or improvement to you?

Nice to have, this feature would make using Kurtosis more enjoyable.

h4ck3rk3y added a commit that referenced this issue Mar 15, 2023
…222)

## Description:
PostHttpRequestRecipe had content-type as a required field; we are now
defaulting to application/json

## Is this change user facing?
<!-- A user facing change is one that you should expect a day-to-day
user to encounter or if the change requires user-action upon or before
upgrading. If in doubt, select "Yes" -->
* [x] Yes
* [ ] No

<!-- If yes, please add the  label to this Pull Request -->

## References (if applicable):
#183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants