fix: run_sh doesn't remove new lines from input #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4ck3rk3y
commented
Oct 27, 2023
core/server/api_container/server/startosis_engine/kurtosis_instruction/tasks/run_sh.go
Show resolved
Hide resolved
leoporoli
approved these changes
Oct 27, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.0](0.84.13...0.85.0) (2023-10-30) ### ⚠ BREAKING CHANGES * protobuf definitions for more idiomatic SDKs ([#1586](#1586)) ### Features * Add cli argument to control image download ([#1495](#1495)) ([f210a76](f210a76)) ### Bug Fixes * run_sh doesn't remove new lines from input ([#1642](#1642)) ([a969dff](a969dff)) ### Code Refactoring * protobuf definitions for more idiomatic SDKs ([#1586](#1586)) ([e7ab58a](e7ab58a)), closes [#843](#843) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com> Co-authored-by: leoporoli <leandroporoli@gmail.com>
h4ck3rk3y
pushed a commit
that referenced
this pull request
Oct 31, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.0](0.84.13...0.85.0) (2023-10-30) ### ⚠ BREAKING CHANGES * protobuf definitions for more idiomatic SDKs ([#1586](#1586)) ### Features * Add cli argument to control image download ([#1495](#1495)) ([f210a76](f210a76)) ### Bug Fixes * run_sh doesn't remove new lines from input ([#1642](#1642)) ([a969dff](a969dff)) ### Code Refactoring * protobuf definitions for more idiomatic SDKs ([#1586](#1586)) ([e7ab58a](e7ab58a)), closes [#843](#843) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com> Co-authored-by: leoporoli <leandroporoli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Earlier
cat foo.txt | tr -d '\n'wouldn't work as it would run ascat foo.txt | tr -d ' '