Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add autocomplete for cluster set command #1695

Merged
merged 2 commits into from
Nov 6, 2023
Merged

feat: add autocomplete for cluster set command #1695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3887969
Extract GetClusterList method, use this for cluster set completion
Nov 6, 2023
85ed41b
Method name
Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions cli/cli/commands/cluster/ls/ls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,10 @@ var LsCmd = &lowlevel.LowlevelKurtosisCommand{
}

func run(ctx context.Context, flags *flags.ParsedFlags, args *args.ParsedArgs) error {
kurtosisConfigStore := kurtosis_config.GetKurtosisConfigStore()
configProvider := kurtosis_config.NewKurtosisConfigProvider(kurtosisConfigStore)
kurtosisConfig, err := configProvider.GetOrInitializeConfig()
clusterList, err := GetClusterList()
if err != nil {
return stacktrace.Propagate(err, "Failed to get or initialize Kurtosis configuration")
}
var clusterList []string
for clusterName := range kurtosisConfig.GetKurtosisClusters() {
clusterList = append(clusterList, clusterName)
return stacktrace.Propagate(err, "Failed to get Kurtosis cluster list")
}
sort.Strings(clusterList)

tablePrinter := output_printers.NewTablePrinter(clusterCurrentColumnHeader, clusterNameColumnHeader)

Expand All @@ -60,6 +53,21 @@ func run(ctx context.Context, flags *flags.ParsedFlags, args *args.ParsedArgs) e
return nil
}

func GetClusterList() ([]string, error) {
kurtosisConfigStore := kurtosis_config.GetKurtosisConfigStore()
configProvider := kurtosis_config.NewKurtosisConfigProvider(kurtosisConfigStore)
kurtosisConfig, err := configProvider.GetOrInitializeConfig()
if err != nil {
return []string{}, stacktrace.Propagate(err, "Failed to get or initialize Kurtosis configuration")
}
var clusterList []string
for clusterName := range kurtosisConfig.GetKurtosisClusters() {
clusterList = append(clusterList, clusterName)
}
sort.Strings(clusterList)
return clusterList, nil
}

func isCurrentCluster(clusterName string) bool {
clusterSettingStore := kurtosis_cluster_setting.GetKurtosisClusterSettingStore()
currentClusterName, _ := clusterSettingStore.GetClusterSetting()
Expand Down
11 changes: 10 additions & 1 deletion cli/cli/commands/cluster/set/set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"github.com/kurtosis-tech/kurtosis/cli/cli/command_framework/lowlevel/args"
"github.com/kurtosis-tech/kurtosis/cli/cli/command_framework/lowlevel/flags"
"github.com/kurtosis-tech/kurtosis/cli/cli/command_str_consts"
"github.com/kurtosis-tech/kurtosis/cli/cli/commands/cluster/ls"
"github.com/kurtosis-tech/kurtosis/cli/cli/defaults"
"github.com/kurtosis-tech/kurtosis/cli/cli/helpers/engine_manager"
"github.com/kurtosis-tech/kurtosis/cli/cli/helpers/kurtosis_config_getter"
Expand Down Expand Up @@ -33,7 +34,7 @@ var SetCmd = &lowlevel.LowlevelKurtosisCommand{
IsOptional: false,
DefaultValue: nil,
IsGreedy: false,
ArgCompletionProvider: nil,
ArgCompletionProvider: args.NewManualCompletionsProvider(getCompletions),
ValidationFunc: nil,
},
},
Expand All @@ -42,6 +43,14 @@ var SetCmd = &lowlevel.LowlevelKurtosisCommand{
PostValidationAndRunFunc: nil,
}

func getCompletions(ctx context.Context, flags *flags.ParsedFlags, previousArgs *args.ParsedArgs) ([]string, error) {
clusterList, err := ls.GetClusterList()
if err != nil {
return nil, stacktrace.Propagate(err, "Failed to get Kurtosis cluster list")
}
return clusterList, nil
}

func run(ctx context.Context, flags *flags.ParsedFlags, args *args.ParsedArgs) error {
clusterName, err := args.GetNonGreedyArg(clusterNameArgKey)
if err != nil {
Expand Down