fix: Don't abort build_enclave_manager_webapp with abort_job_if_only_docs_changes #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dartoxian
changed the title
adschwartz
approved these changes
Jan 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.4](0.86.3...0.86.4) (2024-01-10) ### Bug Fixes * Don't abort build_enclave_manager_webapp with abort_job_if_only_docs_changes ([#2038](#2038)) ([150eb5f](150eb5f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
…d tagged commits (#2041) ## Description: Yesterday we [removed](#2038) the logic which skips `build_enclave_manager_webapp` if the build commit diff against `main` has only docs changes. We did this because we want `build_enclave_manager_webapp` to run on `main` during publish - so that commit would always have no diff from `main` (as it would be the same commit. This change means that we skip `build_enclave_manager_webapp` only if the current commit is not tagged and the diff against main has no changes other than docs changes. This restores the previous behaviour, with the exception that `build_enclave_manager_webapp` runs on tagged commits - ie it can run during publish jobs. ## Is this change user facing? NO ## References (if applicable): * #2038
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
By aborting
build_enclave_manager_webappwithabort_job_if_only_docs_changesthe abort will always occur if the build runs onmain(as the diff there betweenmainandHEADwill always be empty).We need
build_enclave_manager_webappto run onmainso that it can be consumed by thepublish_engine_server_imagetask.Is this change user facing?
NO
References (if applicable):