-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: image load #2102
Closed
Closed
feat: image load #2102
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
container-engine-lib/lib/backend_interface/mock_kurtosis_backend.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
48 changes: 48 additions & 0 deletions
48
container-engine-lib/lib/backend_interface/objects/image_load/image_load.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
package image_load | ||
|
||
import ( | ||
"encoding/json" | ||
|
||
"github.com/kurtosis-tech/stacktrace" | ||
) | ||
|
||
type ImageLoad struct { | ||
// we do this way in order to have exported fields which can be marshalled | ||
// and an unexported type for encapsulation | ||
privateImageLoad *privateImageLoad | ||
} | ||
|
||
// ImageLoad contains the information need for building a container image. | ||
type privateImageLoad struct { | ||
// Location of the container image to load (eg. tar.gz) on the machine | ||
ContainerImageFilePath string | ||
} | ||
|
||
func NewImageLoad(containerImageFilePath string) *ImageLoad { | ||
internalImageLoad := &privateImageLoad{ | ||
ContainerImageFilePath: containerImageFilePath, | ||
} | ||
return &ImageLoad{internalImageLoad} | ||
} | ||
|
||
func (imageLoad *ImageLoad) GetContainerImageFilePath() string { | ||
return imageLoad.privateImageLoad.ContainerImageFilePath | ||
} | ||
|
||
func (imageLoad *ImageLoad) MarshalJSON() ([]byte, error) { | ||
return json.Marshal(imageLoad.privateImageLoad) | ||
} | ||
|
||
func (imageLoad *ImageLoad) UnmarshalJSON(data []byte) error { | ||
|
||
// Suppressing exhaustruct requirement because we want an object with zero values | ||
// nolint: exhaustruct | ||
unmarshalledPrivateStructPtr := &privateImageLoad{} | ||
|
||
if err := json.Unmarshal(data, unmarshalledPrivateStructPtr); err != nil { | ||
return stacktrace.Propagate(err, "An error occurred unmarshalling the private struct") | ||
} | ||
|
||
imageLoad.privateImageLoad = unmarshalledPrivateStructPtr | ||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a usecase for this? I'd imagine users would be either a) specifying an existing Docker image, or b) getting an image through indirect means (either
ImageBuildSpec
orNixBuildSpec
)