feat: Make the cloud instance config available to the EM UI #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentluce
commented
Apr 2, 2024
laurentluce
commented
Apr 2, 2024
laurentluce
changed the title
h4ck3rk3y
approved these changes
Apr 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
## Description We describe the instance termination policy on the tier page and on the cloud UI but those might not be seen until the user starts using the EM UI. The user sees the enclaves deletion as a bug because the instance replacement is done in the background. This change adds an instance termination warning message to the EM UI. Most of the work was done in the following PR to make the cloud instance config available to the EM UI: #2350  ## Is this change user facing? YES
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.88.14](0.88.13...0.88.14) (2024-04-04) ### Features * Add instance termination warning to the enclave manager UI ([#2356](#2356)) ([bb39d2c](bb39d2c)) * Make the cloud instance config available to the EM UI ([#2350](#2350)) ([8b9b5ce](8b9b5ce)) * take access token in body for consistency in port endpoints ([#2351](#2351)) ([7f6f30a](7f6f30a)) ### Bug Fixes * get for port auth instead of post ([#2353](#2353)) ([1ed7978](1ed7978)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The EM UI needs to retrieve the cloud instance config as part of the instance termination warning work. We add this method to the EM API. The cloud api requires typescript bindings so the GetCloudInstanceConfig response definition can be found.
Is this change user facing?
NO