Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add suffix to fluentbit configurator #2567

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mslipper
Copy link

Description

We run Kurtosis in our CI pipeline. Multiple processes create Kurtosis enclaves concurrenctly. When the timing is just right, it can lead to a race condition where the fluentbit configurator container sticks around and no further enclaves can be created until we manually delete the fluentbit container.

This PR adds a suffix to the configurator container so that it is isolated from other concurrent runs.

Is this change user facing?

No

@mslipper mslipper changed the title fix: add suffix to fluentd configurator fix: add suffix to fluentbit configurator Oct 16, 2024
We run Kurtosis in our CI pipeline. Multiple processes create Kurtosis enclaves concurrenctly. When the timing is just right, it can lead to a race condition where the fluentbit configurator container sticks around and no further enclaves can be created until we manually delete the fluentbit container.

This PR adds a suffix to the configurator container so that it is isolated from other concurrent runs.
@mslipper mslipper force-pushed the bugfix/fluentd-configurator-name branch from 669fd06 to 7071c2e Compare October 16, 2024 22:22
@mslipper
Copy link
Author

cc @kurtosis-tech/engineers for review.

@tedim52
Copy link
Contributor

tedim52 commented Oct 22, 2024

Once this is merged, the CI should pass so I'll rerun them. #2572.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants