テストクラスへのTimeout フィールド追加処理を実装 #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,7 +138,9 @@ public void changeGeneration() { | |||
|
|
|||
| private Variant createInitialVariant() { | |||
| final GeneratedSourceCode sourceCode = strategies.execASTConstruction(targetProject); | |||
| return createVariant(new Gene(Collections.emptyList()), sourceCode, | |||
| final Operation operation = new InsertTimeoutRuleFieldOperation(10); | |||
There was a problem hiding this comment.
タイムアウト時間はconfigから取り出すべき
config.getTestTimeLimitSeconds()
There was a problem hiding this comment.
sorry きちんと読んでなかった．
Timeout時間がハードコードなのでConfigに吸い出す必要あり
これすぐできる？
Configから吸い出せたほうが実験がかなりやりやすくなる．
|
これで #341 も解決されることを確認． |
This was referenced Nov 14, 2018
Closed
|
@shinsuke-mat 修正しました。よろしくお願いします。 |
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #372
テストクラスにTimeoutを設定するフィールドを追加する処理を、initialVariant生成時に追加
ソースコードが変更されていることは確認したが、実際にTimeoutされるかは確認していない
Timeout時間がハードコードなのでConfigに吸い出す必要あり