Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production/Development builds #26

Closed
7 tasks
kuzn-ilya opened this issue Oct 10, 2018 · 1 comment
Closed
7 tasks

Production/Development builds #26

kuzn-ilya opened this issue Oct 10, 2018 · 1 comment

Comments

@kuzn-ilya
Copy link
Owner

kuzn-ilya commented Oct 10, 2018 •
edited
Loading

Now there is no bundle for production build, actually we have only development build.
Proposed change:

  • Build bundles via rollup api, not via rollup.config.js
  • Build two bundles: one for prod and another for dev.
  • Remove prop-types usage from prod build:
    • Add eslint rule react/forbid-foreign-prop-types
    • Add babel-plugin-transform-react-remove-prop-types into plugins
  • remove warning function usage from prod build.
  • to be checked remove invariant messages from prod build.
kuzn-ilya added a commit that referenced this issue Oct 10, 2018
@kuzn-ilya
Merge pull request #27 from kuzn-ilya/feat/#26
4d96981 
Feat/#26
kuzn-ilya pushed a commit that referenced this issue Oct 10, 2018
@semantic-release-bot
chore(release): 0.4.0 [skip ci]
8544ce7 
# [0.4.0](v0.3.1...v0.4.0) (2018-10-10)

### Features

* split build into production and development ([d3e20b2](d3e20b2)), closes [#26](#26)
@kuzn-ilya
Copy link
Owner Author

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kuzn-ilya