Superscalar metrics #61
Merged
+398
−314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekcyjna123
reviewed
Feb 28, 2025
|
|
||
| Should be called in the body of either a transaction or a method. | ||
| incr: Methods |
There was a problem hiding this comment.
I think that something went wrong here. Why this docstring is in such weird place?
There was a problem hiding this comment.
Docstring for attributes is written after the attribute, as PEP 257 describes. An alternative would be to remove the method docstrings entirely and add info at the beginning of the class, as we do in other places in Transactron and Coreblocks. Still, this style seems to have some benefits, including being shown contextually in IDEs.
lekcyjna123
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies metrics to enable superscalar use - changing a metric multiple times in a single clock cycle. This is needed to be able to create superscalar circuits which utilize metrics.
The PR introduces a small syntactic change to method calls: the
enablesignal is renamed toenable_calland can be used as a keyword argument. This means thatenable_callis now a reserved argument name. This was done to be able to remove method wrapper functions from metrics modules, which utilized an optionalcondargument - which is basicallyenable. I'm not extra happy with the solution, but it gets the job done.TODO: