Change default interpretation of real literals from DOUBLE to DECIMAL #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing because this idea takes a lot of work; possibly reopen if revisiting this project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In principle should fix #3949
Breaks a million other tests because decimal -> string formatting is slightly different from double -> string formatting, leading to errors where tests expect 1.000000 but get 1.0. This is probably not the only cause but it's very prevalent
Uses inferMinimalType from the
csv-sniffingbranch to determine whether or not the string should be interpreted as a decimal or double.Contributor agreement