Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dummy transaction from extension #4239

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Sep 11, 2024

Description

Please include a summary of the changes and the related issue (if applicable). Please also include
relevant motivation and context.

Fixes # (issue)

Contributor agreement

@ray6080 ray6080 changed the title try to get rid of dummy transaction when creating foreign table Remove dummy transaction from extension Sep 11, 2024
@ray6080 ray6080 force-pushed the foreign-table-transaction branch from f78e5ef to a9bf8d7 Compare September 21, 2024 20:29
@andyfengHKU andyfengHKU marked this pull request as ready for review October 8, 2024 02:32
@ray6080 ray6080 force-pushed the foreign-table-transaction branch from 35b2079 to 467a81b Compare February 3, 2025 14:30
@ray6080 ray6080 force-pushed the foreign-table-transaction branch from fa3c29a to 1335346 Compare February 3, 2025 17:00
@ray6080 ray6080 force-pushed the foreign-table-transaction branch from df10bbd to 16e3cb8 Compare February 4, 2025 03:11
@kuzudb kuzudb deleted a comment from github-actions bot Feb 4, 2025
@kuzudb kuzudb deleted a comment from codecov bot Feb 4, 2025
@kuzudb kuzudb deleted a comment from github-actions bot Feb 4, 2025
@kuzudb kuzudb deleted a comment from github-actions bot Feb 4, 2025
@kuzudb kuzudb deleted a comment from github-actions bot Feb 4, 2025
@kuzudb kuzudb deleted a comment from github-actions bot Feb 4, 2025
@ray6080 ray6080 removed the request for review from benjaminwinger February 4, 2025 03:12
Copy link

github-actions bot commented Feb 4, 2025

Benchmark Result

Master commit hash: 68d829ee48035b7e7aa08b8e539fe206da074634
Branch commit hash: 38c8b904d5a0306e5386484a135d7bc21721ca0f

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 697.59 688.09 9.50 (1.38%)
aggregation q28 6363.22 6349.28 13.94 (0.22%)
filter q14 136.69 128.13 8.57 (6.69%)
filter q15 134.98 125.34 9.64 (7.69%)
filter q16 307.65 306.80 0.84 (0.27%)
filter q17 455.92 448.92 7.00 (1.56%)
filter q18 1956.98 1948.09 8.89 (0.46%)
filter zonemap-node 96.68 89.25 7.44 (8.33%)
filter zonemap-node-lhs-cast 96.97 89.57 7.40 (8.26%)
filter zonemap-node-null 96.58 89.18 7.40 (8.29%)
filter zonemap-rel 5646.73 5693.85 -47.12 (-0.83%)
fixed_size_expr_evaluator q07 585.65 572.14 13.51 (2.36%)
fixed_size_expr_evaluator q08 811.57 802.95 8.62 (1.07%)
fixed_size_expr_evaluator q09 809.00 799.99 9.01 (1.13%)
fixed_size_expr_evaluator q10 244.98 236.76 8.23 (3.47%)
fixed_size_expr_evaluator q11 237.93 231.40 6.53 (2.82%)
fixed_size_expr_evaluator q12 234.47 226.48 7.99 (3.53%)
fixed_size_expr_evaluator q13 1464.78 1461.68 3.10 (0.21%)
fixed_size_seq_scan q23 120.98 115.76 5.22 (4.51%)
join q29 617.69 635.52 -17.82 (-2.80%)
join q30 9499.85 10285.44 -785.59 (-7.64%)
join q31 4.53 7.62 -3.10 (-40.62%)
join SelectiveTwoHopJoin 53.00 52.30 0.70 (1.35%)
ldbc_snb_ic q35 2640.16 2580.48 59.68 (2.31%)
ldbc_snb_ic q36 479.35 476.49 2.86 (0.60%)
ldbc_snb_is q32 5.29 6.74 -1.46 (-21.62%)
ldbc_snb_is q33 12.79 12.97 -0.18 (-1.39%)
ldbc_snb_is q34 1.50 1.33 0.17 (13.15%)
multi-rel multi-rel-large-scan 1332.05 1386.28 -54.23 (-3.91%)
multi-rel multi-rel-lookup 11.68 45.26 -33.58 (-74.20%)
multi-rel multi-rel-small-scan 54.70 74.31 -19.61 (-26.39%)
order_by q25 138.78 132.85 5.93 (4.46%)
order_by q26 458.64 454.49 4.16 (0.91%)
order_by q27 1471.22 1472.93 -1.71 (-0.12%)
recursive_join recursive-join-bidirection 285.61 287.60 -1.99 (-0.69%)
recursive_join recursive-join-dense 7329.61 7331.86 -2.25 (-0.03%)
recursive_join recursive-join-path 23676.87 23736.81 -59.93 (-0.25%)
recursive_join recursive-join-sparse 1065.20 1059.26 5.94 (0.56%)
recursive_join recursive-join-trail 7304.75 7277.28 27.47 (0.38%)
scan_after_filter q01 180.16 171.86 8.30 (4.83%)
scan_after_filter q02 166.29 155.48 10.81 (6.96%)
shortest_path_ldbc100 q37 102.65 97.35 5.30 (5.45%)
shortest_path_ldbc100 q38 387.68 370.39 17.28 (4.67%)
shortest_path_ldbc100 q39 66.46 60.23 6.23 (10.34%)
shortest_path_ldbc100 q40 425.21 453.99 -28.78 (-6.34%)
var_size_expr_evaluator q03 2122.02 2070.20 51.82 (2.50%)
var_size_expr_evaluator q04 2260.63 2210.68 49.95 (2.26%)
var_size_expr_evaluator q05 2663.18 2587.97 75.21 (2.91%)
var_size_expr_evaluator q06 1348.16 1338.07 10.09 (0.75%)
var_size_seq_scan q19 1475.27 1450.73 24.54 (1.69%)
var_size_seq_scan q20 2562.47 2603.38 -40.91 (-1.57%)
var_size_seq_scan q21 2292.43 2273.94 18.49 (0.81%)
var_size_seq_scan q22 130.19 125.03 5.16 (4.13%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants