Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically linking runtime for Windows compilation #4785

Closed
wants to merge 21 commits into from
Closed

Statically linking runtime for Windows compilation #4785

wants to merge 21 commits into from
+21 −10

Conversation

mewim
Copy link
Member

@mewim mewim commented Jan 24, 2025

No description provided.

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 8887b45b7b9326662fa79de921221f366e023fa9
Branch commit hash: 6cd09a55ea542ed920cc5fc8fa351b200c4f2669

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 690.12 698.26 -8.14 (-1.17%)
aggregation q28 6082.35 6080.69 1.67 (0.03%)
filter q14 128.18 133.65 -5.47 (-4.09%)
filter q15 128.73 132.18 -3.45 (-2.61%)
filter q16 304.48 307.18 -2.70 (-0.88%)
filter q17 448.56 453.77 -5.21 (-1.15%)
filter q18 1912.88 1912.94 -0.07 (-0.00%)
filter zonemap-node 89.14 98.63 -9.49 (-9.62%)
filter zonemap-node-lhs-cast 91.12 98.85 -7.73 (-7.82%)
filter zonemap-node-null 87.20 93.96 -6.75 (-7.19%)
filter zonemap-rel 5740.93 5805.77 -64.84 (-1.12%)
fixed_size_expr_evaluator q07 573.35 581.81 -8.45 (-1.45%)
fixed_size_expr_evaluator q08 802.28 809.63 -7.35 (-0.91%)
fixed_size_expr_evaluator q09 802.71 811.20 -8.49 (-1.05%)
fixed_size_expr_evaluator q10 236.64 244.58 -7.93 (-3.24%)
fixed_size_expr_evaluator q11 229.45 237.12 -7.67 (-3.23%)
fixed_size_expr_evaluator q12 226.27 234.14 -7.87 (-3.36%)
fixed_size_expr_evaluator q13 1457.13 1471.61 -14.47 (-0.98%)
fixed_size_seq_scan q23 112.22 119.17 -6.94 (-5.83%)
join q29 604.18 617.80 -13.62 (-2.20%)
join q30 10280.88 10913.70 -632.83 (-5.80%)
join q31 3.97 6.37 -2.40 (-37.66%)
join SelectiveTwoHopJoin 60.95 53.40 7.56 (14.15%)
ldbc_snb_ic q35 2593.30 2587.94 5.36 (0.21%)
ldbc_snb_ic q36 486.06 483.60 2.46 (0.51%)
ldbc_snb_is q32 6.81 6.59 0.22 (3.30%)
ldbc_snb_is q33 15.91 15.66 0.25 (1.58%)
ldbc_snb_is q34 1.45 1.38 0.07 (5.34%)
multi-rel multi-rel-large-scan 1292.97 1343.84 -50.87 (-3.79%)
multi-rel multi-rel-lookup 32.48 44.02 -11.54 (-26.22%)
multi-rel multi-rel-small-scan 87.40 60.27 27.13 (45.01%)
order_by q25 132.83 142.75 -9.93 (-6.96%)
order_by q26 455.37 466.59 -11.21 (-2.40%)
order_by q27 1464.35 1467.64 -3.30 (-0.22%)
recursive_join recursive-join-bidirection 331.91 287.57 44.34 (15.42%)
recursive_join recursive-join-dense 7476.70 7462.52 14.18 (0.19%)
recursive_join recursive-join-path 23749.82 23499.67 250.14 (1.06%)
recursive_join recursive-join-sparse 1052.64 1051.12 1.52 (0.14%)
recursive_join recursive-join-trail 7414.91 7432.43 -17.52 (-0.24%)
scan_after_filter q01 180.75 179.40 1.35 (0.75%)
scan_after_filter q02 166.92 166.06 0.86 (0.52%)
shortest_path_ldbc100 q37 76.88 92.65 -15.77 (-17.02%)
shortest_path_ldbc100 q38 366.88 383.31 -16.42 (-4.28%)
shortest_path_ldbc100 q39 68.62 63.18 5.44 (8.60%)
shortest_path_ldbc100 q40 469.17 389.82 79.35 (20.36%)
var_size_expr_evaluator q03 2072.94 2087.81 -14.87 (-0.71%)
var_size_expr_evaluator q04 2212.59 2208.76 3.83 (0.17%)
var_size_expr_evaluator q05 2624.37 2610.24 14.13 (0.54%)
var_size_expr_evaluator q06 1337.26 1341.00 -3.74 (-0.28%)
var_size_seq_scan q19 1449.78 1455.70 -5.92 (-0.41%)
var_size_seq_scan q20 2626.14 2733.72 -107.58 (-3.94%)
var_size_seq_scan q21 2278.70 2322.48 -43.78 (-1.89%)
var_size_seq_scan q22 125.29 127.67 -2.38 (-1.87%)

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (9cb276f) to head (84fc894).
Report is 17 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4785      +/-   ##
==========================================
- Coverage   86.34%   86.33%   -0.01%     
==========================================
  Files        1397     1399       +2     
  Lines       60082    60299     +217     
  Branches     7387     7417      +30     
==========================================
+ Hits        51879    52061     +182     
- Misses       8036     8072      +36     
+ Partials      167      166       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim changed the title [DO NOT MERGE] Windows runtime debug Use static linking for Windows compilation Jan 24, 2025
@mewim mewim changed the title Use static linking for Windows compilation Statically linking runtime for Windows compilation Jan 24, 2025
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 95759e1c675e0799b701a56fe912d170167a6ad9
Branch commit hash: 2c5134c15f8c9b3a1a8b8f341b6859dbbc68dcc4

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 689.64 708.77 -19.14 (-2.70%)
aggregation q28 6071.94 6083.83 -11.89 (-0.20%)
filter q14 127.69 127.37 0.32 (0.25%)
filter q15 129.79 123.95 5.85 (4.72%)
filter q16 305.23 304.20 1.03 (0.34%)
filter q17 449.07 449.94 -0.87 (-0.19%)
filter q18 1914.49 1916.04 -1.56 (-0.08%)
filter zonemap-node 91.07 89.21 1.85 (2.08%)
filter zonemap-node-lhs-cast 90.43 91.14 -0.71 (-0.78%)
filter zonemap-node-null 85.93 86.56 -0.63 (-0.73%)
filter zonemap-rel 5741.59 5714.00 27.59 (0.48%)
fixed_size_expr_evaluator q07 572.05 574.35 -2.30 (-0.40%)
fixed_size_expr_evaluator q08 802.10 804.29 -2.19 (-0.27%)
fixed_size_expr_evaluator q09 802.13 804.32 -2.19 (-0.27%)
fixed_size_expr_evaluator q10 237.42 239.42 -2.00 (-0.83%)
fixed_size_expr_evaluator q11 230.26 230.86 -0.61 (-0.26%)
fixed_size_expr_evaluator q12 226.77 226.15 0.62 (0.27%)
fixed_size_expr_evaluator q13 1460.54 1456.74 3.80 (0.26%)
fixed_size_seq_scan q23 112.48 114.47 -1.99 (-1.74%)
join q29 622.32 655.31 -32.99 (-5.03%)
join q30 11504.68 10579.67 925.01 (8.74%)
join q31 6.46 7.50 -1.03 (-13.80%)
join SelectiveTwoHopJoin 54.72 55.42 -0.69 (-1.25%)
ldbc_snb_ic q35 2518.49 2571.16 -52.67 (-2.05%)
ldbc_snb_ic q36 502.95 493.54 9.41 (1.91%)
ldbc_snb_is q32 5.46 3.97 1.49 (37.43%)
ldbc_snb_is q33 15.11 10.23 4.88 (47.68%)
ldbc_snb_is q34 1.45 1.39 0.06 (4.58%)
multi-rel multi-rel-large-scan 1295.95 1317.39 -21.44 (-1.63%)
multi-rel multi-rel-lookup 18.65 24.05 -5.40 (-22.45%)
multi-rel multi-rel-small-scan 72.96 61.57 11.39 (18.49%)
order_by q25 133.02 127.01 6.02 (4.74%)
order_by q26 451.17 454.51 -3.33 (-0.73%)
order_by q27 1463.00 1475.60 -12.60 (-0.85%)
recursive_join recursive-join-bidirection 298.61 310.58 -11.97 (-3.85%)
recursive_join recursive-join-dense 7468.39 7477.05 -8.66 (-0.12%)
recursive_join recursive-join-path 23690.94 23969.03 -278.09 (-1.16%)
recursive_join recursive-join-sparse 1055.32 1062.12 -6.80 (-0.64%)
recursive_join recursive-join-trail 7414.36 7436.77 -22.41 (-0.30%)
scan_after_filter q01 170.00 171.58 -1.59 (-0.93%)
scan_after_filter q02 157.43 157.62 -0.19 (-0.12%)
shortest_path_ldbc100 q37 82.14 89.88 -7.73 (-8.60%)
shortest_path_ldbc100 q38 367.03 381.19 -14.16 (-3.71%)
shortest_path_ldbc100 q39 65.31 64.68 0.64 (0.99%)
shortest_path_ldbc100 q40 463.47 466.18 -2.71 (-0.58%)
var_size_expr_evaluator q03 2075.31 2100.96 -25.65 (-1.22%)
var_size_expr_evaluator q04 2209.58 2214.41 -4.84 (-0.22%)
var_size_expr_evaluator q05 2623.59 2621.04 2.56 (0.10%)
var_size_expr_evaluator q06 1341.89 1334.15 7.74 (0.58%)
var_size_seq_scan q19 1450.79 1457.34 -6.55 (-0.45%)
var_size_seq_scan q20 2638.98 2633.79 5.19 (0.20%)
var_size_seq_scan q21 2271.56 2264.31 7.24 (0.32%)
var_size_seq_scan q22 123.94 125.37 -1.43 (-1.14%)

@mewim mewim requested a review from benjaminwinger as a code owner January 24, 2025 10:34
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 95759e1c675e0799b701a56fe912d170167a6ad9
Branch commit hash: 096722428ecb74f4d37bcfc3ab0f5cac4b6ffb4e

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 690.13 708.77 -18.64 (-2.63%)
aggregation q28 6121.59 6083.83 37.76 (0.62%)
filter q14 128.50 127.37 1.13 (0.89%)
filter q15 130.29 123.95 6.35 (5.12%)
filter q16 305.96 304.20 1.76 (0.58%)
filter q17 448.14 449.94 -1.80 (-0.40%)
filter q18 1928.66 1916.04 12.62 (0.66%)
filter zonemap-node 89.79 89.21 0.58 (0.64%)
filter zonemap-node-lhs-cast 89.67 91.14 -1.47 (-1.61%)
filter zonemap-node-null 84.81 86.56 -1.74 (-2.02%)
filter zonemap-rel 5715.70 5714.00 1.70 (0.03%)
fixed_size_expr_evaluator q07 573.88 574.35 -0.47 (-0.08%)
fixed_size_expr_evaluator q08 805.50 804.29 1.22 (0.15%)
fixed_size_expr_evaluator q09 803.59 804.32 -0.72 (-0.09%)
fixed_size_expr_evaluator q10 237.62 239.42 -1.80 (-0.75%)
fixed_size_expr_evaluator q11 229.40 230.86 -1.47 (-0.64%)
fixed_size_expr_evaluator q12 228.44 226.15 2.28 (1.01%)
fixed_size_expr_evaluator q13 1457.20 1456.74 0.46 (0.03%)
fixed_size_seq_scan q23 110.73 114.47 -3.74 (-3.27%)
join q29 610.43 655.31 -44.87 (-6.85%)
join q30 11636.12 10579.67 1056.45 (9.99%)
join q31 6.59 7.50 -0.90 (-12.03%)
join SelectiveTwoHopJoin 55.03 55.42 -0.39 (-0.70%)
ldbc_snb_ic q35 2578.17 2571.16 7.01 (0.27%)
ldbc_snb_ic q36 492.76 493.54 -0.79 (-0.16%)
ldbc_snb_is q32 3.94 3.97 -0.03 (-0.81%)
ldbc_snb_is q33 15.58 10.23 5.35 (52.26%)
ldbc_snb_is q34 1.44 1.39 0.05 (3.65%)
multi-rel multi-rel-large-scan 1291.62 1317.39 -25.77 (-1.96%)
multi-rel multi-rel-lookup 10.69 24.05 -13.36 (-55.55%)
multi-rel multi-rel-small-scan 59.39 61.57 -2.18 (-3.54%)
order_by q25 131.98 127.01 4.97 (3.91%)
order_by q26 453.95 454.51 -0.56 (-0.12%)
order_by q27 1469.04 1475.60 -6.56 (-0.44%)
recursive_join recursive-join-bidirection 287.30 310.58 -23.28 (-7.49%)
recursive_join recursive-join-dense 7507.45 7477.05 30.40 (0.41%)
recursive_join recursive-join-path 23597.37 23969.03 -371.66 (-1.55%)
recursive_join recursive-join-sparse 1055.61 1062.12 -6.50 (-0.61%)
recursive_join recursive-join-trail 7444.38 7436.77 7.61 (0.10%)
scan_after_filter q01 173.74 171.58 2.15 (1.26%)
scan_after_filter q02 157.56 157.62 -0.07 (-0.04%)
shortest_path_ldbc100 q37 95.50 89.88 5.63 (6.26%)
shortest_path_ldbc100 q38 389.83 381.19 8.64 (2.27%)
shortest_path_ldbc100 q39 58.73 64.68 -5.95 (-9.20%)
shortest_path_ldbc100 q40 466.89 466.18 0.70 (0.15%)
var_size_expr_evaluator q03 2079.01 2100.96 -21.95 (-1.04%)
var_size_expr_evaluator q04 2213.93 2214.41 -0.48 (-0.02%)
var_size_expr_evaluator q05 2623.85 2621.04 2.82 (0.11%)
var_size_expr_evaluator q06 1337.54 1334.15 3.39 (0.25%)
var_size_seq_scan q19 1454.78 1457.34 -2.56 (-0.18%)
var_size_seq_scan q20 2631.83 2633.79 -1.96 (-0.07%)
var_size_seq_scan q21 2263.94 2264.31 -0.37 (-0.02%)
var_size_seq_scan q22 125.10 125.37 -0.28 (-0.22%)

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: a365e5b4da27dcab5f679946e6630dc6e2bf0dc6
Branch commit hash: 50fbe269b6eddf89c8d6515519f2b9afbfa178ed

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 689.54 699.28 -9.74 (-1.39%)
aggregation q28 6076.77 6093.27 -16.50 (-0.27%)
filter q14 127.72 126.01 1.71 (1.36%)
filter q15 126.68 123.58 3.11 (2.52%)
filter q16 312.48 309.69 2.79 (0.90%)
filter q17 446.53 444.83 1.70 (0.38%)
filter q18 1937.69 1950.48 -12.79 (-0.66%)
filter zonemap-node 90.49 89.76 0.73 (0.82%)
filter zonemap-node-lhs-cast 89.41 88.83 0.59 (0.66%)
filter zonemap-node-null 85.36 85.98 -0.62 (-0.72%)
filter zonemap-rel 5737.74 5742.45 -4.71 (-0.08%)
fixed_size_expr_evaluator q07 573.02 574.38 -1.36 (-0.24%)
fixed_size_expr_evaluator q08 809.05 802.20 6.85 (0.85%)
fixed_size_expr_evaluator q09 804.15 803.79 0.37 (0.05%)
fixed_size_expr_evaluator q10 237.28 237.68 -0.40 (-0.17%)
fixed_size_expr_evaluator q11 230.31 231.10 -0.79 (-0.34%)
fixed_size_expr_evaluator q12 227.69 229.81 -2.12 (-0.92%)
fixed_size_expr_evaluator q13 1453.09 1450.71 2.38 (0.16%)
fixed_size_seq_scan q23 111.57 109.82 1.75 (1.59%)
join q29 606.07 573.25 32.82 (5.73%)
join q30 11741.31 10836.25 905.05 (8.35%)
join q31 5.65 7.79 -2.14 (-27.44%)
join SelectiveTwoHopJoin 52.45 59.50 -7.04 (-11.84%)
ldbc_snb_ic q35 2592.29 2587.33 4.96 (0.19%)
ldbc_snb_ic q36 463.19 474.32 -11.12 (-2.35%)
ldbc_snb_is q32 6.62 4.37 2.25 (51.37%)
ldbc_snb_is q33 14.00 11.78 2.22 (18.86%)
ldbc_snb_is q34 1.30 1.48 -0.18 (-12.13%)
multi-rel multi-rel-large-scan 1326.90 1500.82 -173.92 (-11.59%)
multi-rel multi-rel-lookup 31.69 42.07 -10.38 (-24.68%)
multi-rel multi-rel-small-scan 66.50 91.33 -24.83 (-27.19%)
order_by q25 132.17 133.90 -1.74 (-1.30%)
order_by q26 450.35 450.30 0.05 (0.01%)
order_by q27 1497.05 1485.91 11.15 (0.75%)
recursive_join recursive-join-bidirection 257.76 308.18 -50.42 (-16.36%)
recursive_join recursive-join-dense 7466.89 7517.04 -50.15 (-0.67%)
recursive_join recursive-join-path 23790.56 23821.20 -30.64 (-0.13%)
recursive_join recursive-join-sparse 1060.64 1059.91 0.73 (0.07%)
recursive_join recursive-join-trail 7398.25 7416.03 -17.77 (-0.24%)
scan_after_filter q01 172.32 170.55 1.77 (1.04%)
scan_after_filter q02 158.57 157.44 1.14 (0.72%)
shortest_path_ldbc100 q37 87.76 91.69 -3.93 (-4.28%)
shortest_path_ldbc100 q38 377.24 391.14 -13.89 (-3.55%)
shortest_path_ldbc100 q39 67.03 66.88 0.15 (0.22%)
shortest_path_ldbc100 q40 439.73 403.44 36.28 (8.99%)
var_size_expr_evaluator q03 2102.66 2105.19 -2.53 (-0.12%)
var_size_expr_evaluator q04 2248.95 2246.36 2.59 (0.12%)
var_size_expr_evaluator q05 2648.48 2632.18 16.30 (0.62%)
var_size_expr_evaluator q06 1357.64 1356.76 0.88 (0.06%)
var_size_seq_scan q19 1478.26 1476.61 1.64 (0.11%)
var_size_seq_scan q20 2631.99 2631.76 0.23 (0.01%)
var_size_seq_scan q21 2287.66 2289.13 -1.48 (-0.06%)
var_size_seq_scan q22 129.64 128.94 0.71 (0.55%)

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: a365e5b4da27dcab5f679946e6630dc6e2bf0dc6
Branch commit hash: f772ee4f4edc7aacaf3e3b64239d00eb872fdec3

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 690.52 699.28 -8.76 (-1.25%)
aggregation q28 6075.28 6093.27 -17.99 (-0.30%)
filter q14 127.17 126.01 1.15 (0.92%)
filter q15 123.70 123.58 0.13 (0.10%)
filter q16 316.81 309.69 7.12 (2.30%)
filter q17 445.99 444.83 1.16 (0.26%)
filter q18 1952.64 1950.48 2.16 (0.11%)
filter zonemap-node 89.20 89.76 -0.55 (-0.62%)
filter zonemap-node-lhs-cast 88.89 88.83 0.06 (0.07%)
filter zonemap-node-null 84.66 85.98 -1.32 (-1.53%)
filter zonemap-rel 5739.97 5742.45 -2.47 (-0.04%)
fixed_size_expr_evaluator q07 574.19 574.38 -0.19 (-0.03%)
fixed_size_expr_evaluator q08 804.22 802.20 2.03 (0.25%)
fixed_size_expr_evaluator q09 806.46 803.79 2.67 (0.33%)
fixed_size_expr_evaluator q10 238.05 237.68 0.37 (0.16%)
fixed_size_expr_evaluator q11 230.83 231.10 -0.27 (-0.12%)
fixed_size_expr_evaluator q12 226.49 229.81 -3.33 (-1.45%)
fixed_size_expr_evaluator q13 1459.30 1450.71 8.59 (0.59%)
fixed_size_seq_scan q23 108.94 109.82 -0.88 (-0.80%)
join q29 594.70 573.25 21.45 (3.74%)
join q30 11335.27 10836.25 499.02 (4.61%)
join q31 6.24 7.79 -1.54 (-19.84%)
join SelectiveTwoHopJoin 55.01 59.50 -4.49 (-7.55%)
ldbc_snb_ic q35 2589.67 2587.33 2.34 (0.09%)
ldbc_snb_ic q36 450.15 474.32 -24.17 (-5.10%)
ldbc_snb_is q32 4.16 4.37 -0.22 (-4.96%)
ldbc_snb_is q33 13.49 11.78 1.71 (14.49%)
ldbc_snb_is q34 1.52 1.48 0.04 (2.91%)
multi-rel multi-rel-large-scan 1352.99 1500.82 -147.83 (-9.85%)
multi-rel multi-rel-lookup 31.51 42.07 -10.56 (-25.10%)
multi-rel multi-rel-small-scan 102.00 91.33 10.67 (11.68%)
order_by q25 129.06 133.90 -4.84 (-3.62%)
order_by q26 456.52 450.30 6.22 (1.38%)
order_by q27 1485.30 1485.91 -0.61 (-0.04%)
recursive_join recursive-join-bidirection 322.25 308.18 14.07 (4.57%)
recursive_join recursive-join-dense 7500.40 7517.04 -16.64 (-0.22%)
recursive_join recursive-join-path 23697.85 23821.20 -123.35 (-0.52%)
recursive_join recursive-join-sparse 1060.23 1059.91 0.32 (0.03%)
recursive_join recursive-join-trail 7451.14 7416.03 35.11 (0.47%)
scan_after_filter q01 171.44 170.55 0.89 (0.52%)
scan_after_filter q02 159.35 157.44 1.91 (1.21%)
shortest_path_ldbc100 q37 85.61 91.69 -6.08 (-6.63%)
shortest_path_ldbc100 q38 361.71 391.14 -29.42 (-7.52%)
shortest_path_ldbc100 q39 63.73 66.88 -3.16 (-4.72%)
shortest_path_ldbc100 q40 456.88 403.44 53.44 (13.25%)
var_size_expr_evaluator q03 2124.30 2105.19 19.11 (0.91%)
var_size_expr_evaluator q04 2254.98 2246.36 8.63 (0.38%)
var_size_expr_evaluator q05 2637.48 2632.18 5.30 (0.20%)
var_size_expr_evaluator q06 1360.23 1356.76 3.47 (0.26%)
var_size_seq_scan q19 1480.04 1476.61 3.43 (0.23%)
var_size_seq_scan q20 2634.57 2631.76 2.81 (0.11%)
var_size_seq_scan q21 2284.37 2289.13 -4.76 (-0.21%)
var_size_seq_scan q22 130.59 128.94 1.65 (1.28%)

@mewim
Copy link
Member Author

mewim commented Jan 26, 2025

Close in favour of #4796

@mewim mewim closed this Jan 26, 2025
@mewim mewim deleted the test-java branch January 26, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminwinger benjaminwinger Awaiting requested review from benjaminwinger benjaminwinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mewim @benjaminwinger