Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension repo url #4794

Merged
merged 4 commits into from
Jan 26, 2025
Merged

Extension repo url #4794

merged 4 commits into from
Jan 26, 2025

Conversation

acquamarin
Copy link
Collaborator

Fix the generation of extension repo url.
If the user installs extension using upper case extension name:

INSTALL EXTENSION JSON;

Master generated an incorrect extension url because of the upper case JSON.
This PR normalize extension names when generating URLs.

Copy link

Benchmark Result

Master commit hash: b50f21551983bd60f3836d541c475ee7511af80b
Branch commit hash: edc34ea0e3da5393552f0f2709b4dede51fc601d

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 689.33 690.77 -1.44 (-0.21%)
aggregation q28 6084.63 6087.34 -2.71 (-0.04%)
filter q14 126.48 127.56 -1.07 (-0.84%)
filter q15 124.40 126.75 -2.34 (-1.85%)
filter q16 301.34 303.59 -2.25 (-0.74%)
filter q17 448.54 449.26 -0.72 (-0.16%)
filter q18 1920.27 1924.67 -4.40 (-0.23%)
filter zonemap-node 90.42 89.07 1.35 (1.52%)
filter zonemap-node-lhs-cast 90.06 91.11 -1.05 (-1.15%)
filter zonemap-node-null 85.35 86.47 -1.11 (-1.29%)
filter zonemap-rel 5740.95 5752.83 -11.88 (-0.21%)
fixed_size_expr_evaluator q07 571.95 572.02 -0.07 (-0.01%)
fixed_size_expr_evaluator q08 806.42 799.23 7.20 (0.90%)
fixed_size_expr_evaluator q09 807.72 803.03 4.69 (0.58%)
fixed_size_expr_evaluator q10 237.52 284.50 -46.98 (-16.51%)
fixed_size_expr_evaluator q11 229.95 230.19 -0.25 (-0.11%)
fixed_size_expr_evaluator q12 226.58 226.72 -0.14 (-0.06%)
fixed_size_expr_evaluator q13 1458.57 1459.61 -1.03 (-0.07%)
fixed_size_seq_scan q23 111.82 109.09 2.73 (2.50%)
join q29 607.22 592.99 14.23 (2.40%)
join q30 10318.26 10144.82 173.45 (1.71%)
join q31 8.02 5.92 2.09 (35.32%)
join SelectiveTwoHopJoin 54.47 55.12 -0.65 (-1.18%)
ldbc_snb_ic q35 2615.19 2587.62 27.57 (1.07%)
ldbc_snb_ic q36 486.13 464.75 21.38 (4.60%)
ldbc_snb_is q32 5.74 5.93 -0.19 (-3.17%)
ldbc_snb_is q33 13.50 14.90 -1.40 (-9.42%)
ldbc_snb_is q34 1.39 1.49 -0.10 (-6.57%)
multi-rel multi-rel-large-scan 1498.30 1461.80 36.50 (2.50%)
multi-rel multi-rel-lookup 6.22 18.62 -12.40 (-66.61%)
multi-rel multi-rel-small-scan 85.61 104.59 -18.98 (-18.14%)
order_by q25 131.28 137.67 -6.40 (-4.65%)
order_by q26 455.19 456.69 -1.50 (-0.33%)
order_by q27 1455.05 1460.87 -5.81 (-0.40%)
recursive_join recursive-join-bidirection 308.30 294.94 13.36 (4.53%)
recursive_join recursive-join-dense 7338.03 7306.98 31.05 (0.42%)
recursive_join recursive-join-path 23629.20 23732.76 -103.55 (-0.44%)
recursive_join recursive-join-sparse 1058.64 1060.79 -2.15 (-0.20%)
recursive_join recursive-join-trail 7265.77 7282.06 -16.28 (-0.22%)
scan_after_filter q01 172.11 169.72 2.39 (1.41%)
scan_after_filter q02 156.51 156.09 0.42 (0.27%)
shortest_path_ldbc100 q37 90.39 87.44 2.95 (3.38%)
shortest_path_ldbc100 q38 314.92 353.20 -38.28 (-10.84%)
shortest_path_ldbc100 q39 61.83 69.41 -7.58 (-10.92%)
shortest_path_ldbc100 q40 469.56 421.92 47.64 (11.29%)
var_size_expr_evaluator q03 2089.22 2107.91 -18.69 (-0.89%)
var_size_expr_evaluator q04 2206.25 2219.67 -13.41 (-0.60%)
var_size_expr_evaluator q05 2623.23 2651.49 -28.26 (-1.07%)
var_size_expr_evaluator q06 1329.79 1337.24 -7.45 (-0.56%)
var_size_seq_scan q19 1457.27 1457.04 0.23 (0.02%)
var_size_seq_scan q20 2660.42 2659.56 0.86 (0.03%)
var_size_seq_scan q21 2322.89 2274.17 48.72 (2.14%)
var_size_seq_scan q22 125.06 125.57 -0.50 (-0.40%)

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.35%. Comparing base (b50f215) to head (fef4d9e).

Files with missing lines Patch % Lines
src/extension/extension.cpp 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4794   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files        1399     1399           
  Lines       60400    60401    +1     
  Branches     7430     7430           
=======================================
+ Hits        52156    52158    +2     
+ Misses       8078     8077    -1     
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Result

Master commit hash: 977ef304a0b4b834d9114e6bcc5bd4126ee1b3ce
Branch commit hash: 8be10acbdbed7f2dc809af8acd00d0dcc669ec81

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 696.58 697.42 -0.83 (-0.12%)
aggregation q28 6067.76 6052.65 15.11 (0.25%)
copy node-Comment 69216.54 N/A N/A
copy node-Forum 5506.44 N/A N/A
copy node-Organisation 1199.92 N/A N/A
copy node-Person 2068.27 N/A N/A
copy node-Place 1145.91 N/A N/A
copy node-Post 27539.10 N/A N/A
copy node-Tag 1247.56 N/A N/A
copy node-Tagclass 1197.46 N/A N/A
copy rel-comment-hasCreator 54024.59 N/A N/A
copy rel-comment-hasTag 87804.08 N/A N/A
copy rel-comment-isLocatedIn 70026.00 N/A N/A
copy rel-containerOf 14188.64 N/A N/A
copy rel-forum-hasTag 3983.87 N/A N/A
copy rel-hasInterest 3086.17 N/A N/A
copy rel-hasMember 116452.88 N/A N/A
copy rel-hasModerator 1291.95 N/A N/A
copy rel-hasType 252.93 N/A N/A
copy rel-isPartOf 253.68 N/A N/A
copy rel-isSubclassOf 296.50 N/A N/A
copy rel-knows 13475.52 N/A N/A
copy rel-likes-comment 173664.11 N/A N/A
copy rel-likes-post 68060.40 N/A N/A
copy rel-organisation-isLocatedIn 286.36 N/A N/A
copy rel-person-isLocatedIn 475.33 N/A N/A
copy rel-post-hasCreator 14725.68 N/A N/A
copy rel-post-hasTag 22164.94 N/A N/A
copy rel-post-isLocatedIn 18116.60 N/A N/A
copy rel-replyOf-comment 50380.05 N/A N/A
copy rel-replyOf-post 37059.80 N/A N/A
copy rel-studyAt 822.58 N/A N/A
copy rel-workAt 1577.43 N/A N/A
filter q14 134.18 126.66 7.52 (5.93%)
filter q15 145.17 129.06 16.11 (12.48%)
filter q16 367.37 303.82 63.55 (20.92%)
filter q17 453.53 448.96 4.58 (1.02%)
filter q18 1909.03 1929.68 -20.66 (-1.07%)
filter zonemap-node 98.13 90.97 7.16 (7.87%)
filter zonemap-node-lhs-cast 97.84 89.27 8.57 (9.60%)
filter zonemap-node-null 93.30 85.28 8.02 (9.41%)
filter zonemap-rel 5881.61 5766.00 115.61 (2.01%)
fixed_size_expr_evaluator q07 586.84 582.67 4.17 (0.72%)
fixed_size_expr_evaluator q08 821.05 823.24 -2.19 (-0.27%)
fixed_size_expr_evaluator q09 817.69 818.25 -0.56 (-0.07%)
fixed_size_expr_evaluator q10 251.44 241.92 9.52 (3.93%)
fixed_size_expr_evaluator q11 244.08 233.25 10.83 (4.64%)
fixed_size_expr_evaluator q12 241.27 230.40 10.87 (4.72%)
fixed_size_expr_evaluator q13 1470.44 1480.25 -9.82 (-0.66%)
fixed_size_seq_scan q23 127.77 112.31 15.46 (13.77%)
join q29 596.08 627.86 -31.78 (-5.06%)
join q30 10267.82 9975.71 292.12 (2.93%)
join q31 5.20 6.44 -1.24 (-19.23%)
join SelectiveTwoHopJoin 55.69 65.39 -9.70 (-14.84%)
ldbc_snb_ic q35 2629.70 2537.46 92.24 (3.64%)
ldbc_snb_ic q36 465.42 467.03 -1.61 (-0.34%)
ldbc_snb_is q32 6.74 5.42 1.32 (24.43%)
ldbc_snb_is q33 15.43 17.24 -1.81 (-10.49%)
ldbc_snb_is q34 1.59 1.50 0.09 (5.92%)
multi-rel multi-rel-large-scan 1325.31 1320.70 4.61 (0.35%)
multi-rel multi-rel-lookup 45.12 31.78 13.34 (41.97%)
multi-rel multi-rel-small-scan 97.59 86.48 11.11 (12.85%)
order_by q25 139.36 132.17 7.19 (5.44%)
order_by q26 472.69 453.26 19.43 (4.29%)
order_by q27 1469.93 1469.00 0.94 (0.06%)
recursive_join recursive-join-bidirection 295.47 282.30 13.17 (4.66%)
recursive_join recursive-join-dense 7377.96 6722.59 655.37 (9.75%)
recursive_join recursive-join-path 23542.27 23575.95 -33.68 (-0.14%)
recursive_join recursive-join-sparse 1047.78 1054.87 -7.09 (-0.67%)
recursive_join recursive-join-trail 7328.13 7206.73 121.41 (1.68%)
scan_after_filter q01 178.46 171.49 6.97 (4.06%)
scan_after_filter q02 164.86 157.81 7.05 (4.47%)
shortest_path_ldbc100 q37 85.00 84.67 0.33 (0.39%)
shortest_path_ldbc100 q38 344.11 358.61 -14.51 (-4.05%)
shortest_path_ldbc100 q39 61.88 39.21 22.67 (57.81%)
shortest_path_ldbc100 q40 451.06 370.90 80.15 (21.61%)
var_size_expr_evaluator q03 2095.41 2077.70 17.71 (0.85%)
var_size_expr_evaluator q04 2236.74 2222.54 14.21 (0.64%)
var_size_expr_evaluator q05 2688.69 2626.12 62.57 (2.38%)
var_size_expr_evaluator q06 1353.25 1351.59 1.65 (0.12%)
var_size_seq_scan q19 1473.72 1451.82 21.91 (1.51%)
var_size_seq_scan q20 2700.02 2645.03 54.99 (2.08%)
var_size_seq_scan q21 2306.68 2271.60 35.07 (1.54%)
var_size_seq_scan q22 128.34 124.85 3.49 (2.80%)

@acquamarin acquamarin merged commit b7f5adc into master Jan 26, 2025
22 of 23 checks passed
@acquamarin acquamarin deleted the extension-repo-url branch January 26, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants