-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app:scaffold
based on github release instead of git branches
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChillPC
requested review from
Aschen and
Shiranuit
and removed request for
Aschen
October 10, 2022 07:12
Aschen
suggested changes
Oct 17, 2022
Aschen
approved these changes
Oct 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Permit to pull scaffolds based on release (PR related : kuzzleio/project-templates#3).
When directory already exist:
$ ts-node bin/run app:scaffold test2 --flavor 2 🚀 Kourou - Scaffolds a new Kuzzle application ✖ Creating and rendering application files → Directory "test2" already exist
When no asset release with
flavor
name found:How should this be manually tested?
In
src/commands/app/scaffold.ts
, replace:with:
for test and use flavor
generic
oriot-platform
.Other changes
Multi line commands for running the app when finishing scaffolding to ease copy paste.
Module
node-fetch
that should have a stable API.Avoid deprecated Ubuntu version