Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app:scaffold based on github release instead of git branches #156

Merged
merged 16 commits into from
Oct 24, 2022

Conversation

ChillPC
Copy link
Contributor

@ChillPC ChillPC commented Sep 8, 2022

What does this PR do?

Permit to pull scaffolds based on release (PR related : kuzzleio/project-templates#3).

When directory already exist:

$ ts-node bin/run app:scaffold test2 --flavor 2

 🚀 Kourou - Scaffolds a new Kuzzle application

  ✖ Creating and rendering application files
    → Directory "test2" already exist

When no asset release with flavor name found:

$ ts-node bin/run app:scaffold test5 --flavor not-existing

 🚀 Kourou - Scaffolds a new Kuzzle application

  ✖ Creating and rendering application files
    → Scaffold for the flavor "not-existing" does not exist

How should this be manually tested?

In src/commands/app/scaffold.ts, replace:

https://github.com/kuzzleio/project-templates/releases/latest/download/${assetName}`);

with:

https://github.com/ChillPC/multi-release-test/releases/latest/download/${assetName}`);

for test and use flavor generic or iot-platform.

Other changes

Multi line commands for running the app when finishing scaffolding to ease copy paste.

Module node-fetch that should have a stable API.

Avoid deprecated Ubuntu version

@ChillPC ChillPC self-assigned this Sep 8, 2022
@ChillPC ChillPC marked this pull request as draft October 7, 2022 05:46
@ChillPC ChillPC requested review from Aschen and Shiranuit and removed request for Aschen October 10, 2022 07:12
@ChillPC ChillPC marked this pull request as ready for review October 10, 2022 11:18
src/commands/app/scaffold.ts Outdated Show resolved Hide resolved
src/commands/app/scaffold.ts Outdated Show resolved Hide resolved
src/commands/app/scaffold.ts Outdated Show resolved Hide resolved
@ChillPC ChillPC requested a review from Aschen October 24, 2022 13:32
@Aschen Aschen merged commit 7a87c62 into develop Oct 24, 2022
@Aschen Aschen deleted the feat/scaffold-release branch October 24, 2022 14:39
@rolljee rolljee mentioned this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants