-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new version of logs #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a remark on the code.
Apart form that, can you please:
- assign this PR to yourself
- add the label
src/commands/paas/logs.ts
Outdated
return currentName === max.name ? end : end + (max.length - currentName.length); | ||
} | ||
|
||
getRandomChalkColor() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this function you can end up with the same color for 2 pods. Maybe it would be better to iterate over pods with an index and use this index to select a color
I didn't assign myself because the PR wasn't fully completed, and the work will be taken by @Kuruyia i will put this PR as draft and let him add the proper label and assignement 👍 |
@Kuruyia LGTM 👍 I let you merge it since I'm not sure about the release timing for this one |
This can be merged |
Overview
This improves the log output for the PaaS, by using the new back-end API, and by adding more filter options.
The standard output is very similar to what Docker Compose uses so that people are not too bothered by the logs:
What changed?
-f
/--follow
flag to stream the logs from the PaaS in real-time;-n
/--tail
flag to specify the number of logs from the end to receive from each pod;-t
/--timestamp
flag to display the timestamp of each log line;--podName
flag to filter by pod;--since
flag to specify the time from which to retrieve logs;--until
flag to specify the time from which to stop retrieving logs.