Disable websocket heartbeat from the SDK when using the debug-proxy #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebouthinon
approved these changes
Feb 28, 2023
OlivierCavadenti
approved these changes
Feb 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When using the debug-proxy chances are that you may want to take a heap snapshot, taking a heap snapshot freezes the threads of the Kuzzle Node and prevent Kuzzle from responding to the heartbeat request from the SDK resulting in the SDK closing the connection.
However while we are taking the snapshot it is important that the connection stays open otherwise Kuzzle will send the resulting snapshot chunks into the void, so to avoid the SDK from disconnecting itself because it did not receive a response from Kuzzle in a reasonable amount of time, we simply disable the timer responsible for disconnecting the SDK when Kuzzle is not responding while we are using the debug-proxy.