Move ES indices related commands to es:indices namespace #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
approved these changes
Oct 23, 2020
Aschen
changed the title
|
You shouldn't put two different labels since the release tool can only handle one. |
xbill82
approved these changes
Oct 26, 2020
| @@ -3,6 +3,9 @@ | |||
| "vetur.format.defaultFormatter.ts": "prettier", | |||
| "vetur.format.defaultFormatter.js": "prettier-eslint", | |||
| "vetur.format.enable": false, | |||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | |||
| "typescript.tsdk": "node_modules/typescript/lib" | |||
| "editor.defaultFormatter": "vscode.typescript-language-features", | |||
There was a problem hiding this comment.
Are we sure these settings should live here?
Merged
Aschen
added a commit
that referenced
this pull request
Oct 28, 2020
# [0.16.0](https://github.com/kuzzleio/kourou/releases/tag/0.16.0) (2020-10-28) #### Bug fixes - [ [#73](#73) ] Add missing templates app:scaffold ([Aschen](https://github.com/Aschen)) #### New features - [ [#74](#74) ] Redis list keys ([Aschen](https://github.com/Aschen)) #### Enhancement - [ [#72](#72) ] Move ES indices related commands to es:indices namespace ([rolljee](https://github.com/rolljee)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is link to #71
Other changes
Add 1 test for es:indices:insert
Boyscout
Some minor linting