Add sha256 support with old md5 support #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The goal of this PR is to avoid using
MD5
hashes in hexadecimal format as a key foraes-256-cbc
because even if they are 32 bytes long, which should give us 256 bits password entropy(256^32 == 2^256)
which is good at the first look.We know that there would only be hexadecimal characters within the 32 bytes so it reduces the password entropy to 128 bits
(16^32 == 2^128)
.So we use a 256 bits password to encrypt data but we only have a 128 bits for the password entropy.
This is why this PR use
SHA256
instead ofMD5
, to provide 256 bits length password and 256 bits of password entropy, and also support the decryption of old data encrypted withMD5
hashed keys.