-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document controller #135
Document controller #135
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.x #135 +/- ##
==========================================
+ Coverage 87.96% 89.05% +1.08%
==========================================
Files 198 216 +18
Lines 3615 3993 +378
==========================================
+ Hits 3180 3556 +376
- Misses 409 410 +1
- Partials 26 27 +1
Continue to review full report at Codecov.
|
9047646
to
7d2a865
Compare
9bd4d48
to
dda89fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't read everything, I think it's good overall but you removed every QueryOptions of all methods. We should keep them as we want to be able to use the queuable option
c009b0b
to
16f7e43
Compare
int count(char* index, char* collection, char* body)
bool exists(char* index, char* collection, char* _id)
char* create(char* index, char* collection, char* _id, char* body, options* options) // struct { bool wait_for; char* volatile } options;
char* createOrReplace(char* index, char* collection, char* _id, char* body, options* options)
char* delete(char* index, char* collection, char* _id, options* options) // returns delete id
char** deleteByQuery(char* index, char* collection, char* body, options* options)
char* get(char* index, char* collection, char* _id)
char* mCreate(char* index, char* collection, char* body, options* options)
char* mCreateOrReplace(char* index, char* collection, char* body, options* options)
char** mDelete(char* index, char* collection, char** _ids, options* options)
char* mGet(char* index, char* collection, char** _ids, bool includeTrash)
char* mReplace(char* index, char* collection, char* body, options* options)
char* mUpdate(char* index, char* collection, char* body, options* options)
char* replace(char* index, char* collection, char* _id, char* body, options* options)
// not implemented: scroll
*searchResult search(char* index, char* collection, char* body, searchOptions* options)
char* update(char* index, char* collection, char* _id, char* body, options* options)
bool validate(char* index, char* collection, char* body)