Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document controller #135

Merged
merged 14 commits into from
Mar 21, 2018
Merged

Document controller #135

merged 14 commits into from
Mar 21, 2018

Conversation

alexandrebouthinon
Copy link
Member

  • int count(char* index, char* collection, char* body)
  • bool exists(char* index, char* collection, char* _id)
  • char* create(char* index, char* collection, char* _id, char* body, options* options) // struct { bool wait_for; char* volatile } options;
  • char* createOrReplace(char* index, char* collection, char* _id, char* body, options* options)
  • char* delete(char* index, char* collection, char* _id, options* options) // returns delete id
  • char** deleteByQuery(char* index, char* collection, char* body, options* options)
  • char* get(char* index, char* collection, char* _id)
  • char* mCreate(char* index, char* collection, char* body, options* options)
  • char* mCreateOrReplace(char* index, char* collection, char* body, options* options)
  • char** mDelete(char* index, char* collection, char** _ids, options* options)
  • char* mGet(char* index, char* collection, char** _ids, bool includeTrash)
  • char* mReplace(char* index, char* collection, char* body, options* options)
  • char* mUpdate(char* index, char* collection, char* body, options* options)
  • char* replace(char* index, char* collection, char* _id, char* body, options* options)
  • // not implemented: scroll
  • *searchResult search(char* index, char* collection, char* body, searchOptions* options)
  • char* update(char* index, char* collection, char* _id, char* body, options* options)
  • bool validate(char* index, char* collection, char* body)

@codecov-io
Copy link

codecov-io commented Mar 7, 2018

Codecov Report

Merging #135 into 1.x will increase coverage by 1.08%.
The diff coverage is 99.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #135      +/-   ##
==========================================
+ Coverage   87.96%   89.05%   +1.08%     
==========================================
  Files         198      216      +18     
  Lines        3615     3993     +378     
==========================================
+ Hits         3180     3556     +376     
- Misses        409      410       +1     
- Partials       26       27       +1
Impacted Files Coverage Δ
document/createOrReplace.go 100% <100%> (ø)
document/mCreate.go 100% <100%> (ø)
document/delete.go 100% <100%> (ø)
document/mUpdate.go 100% <100%> (ø)
document/mDelete.go 100% <100%> (ø)
document/mGet.go 100% <100%> (ø)
kuzzle/kuzzle.go 35.83% <100%> (+0.53%) ⬆️
document/update.go 100% <100%> (ø)
document/mReplace.go 100% <100%> (ø)
document/document.go 100% <100%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f967f95...ba5ae66. Read the comment docs.

@alexandrebouthinon alexandrebouthinon mentioned this pull request Mar 14, 2018
12 tasks
Copy link
Contributor

@jenow jenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read everything, I think it's good overall but you removed every QueryOptions of all methods. We should keep them as we want to be able to use the queuable option

@alexandrebouthinon alexandrebouthinon merged commit 29965aa into 1.x Mar 21, 2018
@alexandrebouthinon alexandrebouthinon deleted the document_controller branch March 21, 2018 11:30
@jenow jenow mentioned this pull request Sep 10, 2018
@jenow jenow mentioned this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants