Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change void_result to error_result #150

Merged
merged 1 commit into from
May 2, 2018
Merged

Change void_result to error_result #150

merged 1 commit into from
May 2, 2018

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Apr 27, 2018

What does this PR do ?

fix #148

Rename void_result to error_result as it is weird to have a struct named void_result which contains something (errors).
The error_result will be null if no errors are received otherwise it will be allocated and contain the status, error and stack.

How should this be manually tested?

See travis report.

@jenow jenow self-assigned this Apr 27, 2018
@jenow jenow changed the base branch from master to 1.x April 27, 2018 07:38
@jenow jenow changed the title 148 error result Rename void_result to error_result Apr 27, 2018
@jenow jenow changed the title Rename void_result to error_result Change void_result to error_result Apr 27, 2018
@codecov-io
Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #150 into 1.x will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             1.x   #150      +/-   ##
=======================================
+ Coverage   88.9%    89%   +0.09%     
=======================================
  Files        244    244              
  Lines       4382   4382              
=======================================
+ Hits        3896   3900       +4     
+ Misses       455    451       -4     
  Partials      31     31
Impacted Files Coverage Δ
realtime/join.go 78.37% <0%> (+5.4%) ⬆️
realtime/subscribe.go 77.14% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e60bc...a342405. Read the comment docs.

@benoitvidis benoitvidis merged commit 33ae208 into 1.x May 2, 2018
@benoitvidis benoitvidis deleted the 148-error-result branch May 2, 2018 15:37
@jenow jenow mentioned this pull request Sep 10, 2018
@jenow jenow mentioned this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants