Kzl 70 cpp e2e tests #158
Merged
Kzl 70 cpp e2e tests #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And removed absolute path from build
cucumber-cpp changed their build, introduicing the need for another include path to ensure we can find new generated header CukeExport.hpp
Codecov Report
@@ Coverage Diff @@
## 1.x #158 +/- ##
=======================================
Coverage 89.01% 89.01%
=======================================
Files 244 244
Lines 4406 4406
=======================================
Hits 3922 3922
Misses 452 452
Partials 32 32Continue to review full report at Codecov.
|
jenow
suggested changes
May 31, 2018
jenow
suggested changes
May 31, 2018
| @@ -0,0 +1,209 @@ | |||
| <?xml version="1.0" encoding="Windows-1252"?> | |||
There was a problem hiding this comment.
I don't think this should be commited :p
There was a problem hiding this comment.
It's a file that comes with the third party library
There was a problem hiding this comment.
This file is part of the 3rd party lib...
| const char *scope; | ||
| const char *state; | ||
| const char *user; | ||
| const long start; |
There was a problem hiding this comment.
Is it going to be free by the SDK?
…o KZL-70-cpp-e2e-tests
removed const long
jenow
approved these changes
Jun 1, 2018
alexandrebouthinon
approved these changes
Jun 1, 2018
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds automatic testing of C++ SDK framework using cucumber-cpp
How should this be manually tested?
make cppininternal/wrapperinternal/wrappers:build_cpp_tests.sh̀_build_cpp_testsrun./KuzzleSDKStepDefsinternal/wrappers:cucumber features/sdk2.featuresAlternative: launch test in one console:
_build_cpp_tests/KuzzleSDKStepDefs > /dev/null & cucumber features/sdks2.featureor
_build_cpp_tests/KuzzleSDKStepDefs > tests.log & cucumber features/sdks2.featureto keep tests execution logs
KZL-70 (https://jira.kaliop.net/browse/KZL-70)