Generate C# SDK on Linux and Windows #159
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.x #159 +/- ##
==========================================
- Coverage 89.01% 88.93% -0.09%
==========================================
Files 244 244
Lines 4407 4409 +2
==========================================
- Hits 3923 3921 -2
- Misses 452 456 +4
Partials 32 32
Continue to review full report at Codecov.
|
| @@ -3,7 +3,7 @@ go: | |||
| - 1.9 | |||
| dist: trusty | |||
| install: | |||
| - sudo apt-get install -y build-essential swig oracle-java8-installer g++ python3-dev | |||
| - sudo apt-get install -y build-essential swig oracle-java8-installer g++ python3-dev mono-mcs | |||
There was a problem hiding this comment.
Just for my understanding : the dependency on mono here is just required by swig, right?
Can you confirm the generated cs code can be consumed by any CLR implementation (regular.net, .net Core or mono)?
There was a problem hiding this comment.
No it cannot, the final step of the making of the dll is made by mono (mcs). If we want to to do this with regular .net or something else we have to change this.
I am not able to do this as I have absolutely no knowledge about .net and windows in general so I think we should do an issue if we want to include regular .net compiler and how to do it etc.
The goal of this PR is to get a draft of the C# SDK and then get feedbacks from people who knows it to then get a stable C# SDK
There was a problem hiding this comment.
ok, fine by me. I'll try to have a look at if the dll can be consumed by official .Net CLR (I doubt .Net core will) if I find time.
What does this PR do ?
Generate C# SDK for Linux and Windows, compatible Unity
How should this be manually tested?
Follow the instructions on the README
Note
Blocked by #162