Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed .so file in .jar file #175

Merged
merged 2 commits into from
Jul 10, 2018
Merged

embed .so file in .jar file #175

merged 2 commits into from
Jul 10, 2018

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Jul 6, 2018

What does this PR do ?

Embed the .so file inside the .jar file

How should this be manually tested?

cd internal/wrappers
make java
cd build/java/build/libs
jar xf kuzzlesdk-1.0.0.jar

Check if libkuzzle-wrapper-java.so is there

@jenow jenow self-assigned this Jul 6, 2018
@codecov-io
Copy link

codecov-io commented Jul 6, 2018

Codecov Report

Merging #175 into 1.x will decrease coverage by 1.88%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##              1.x   #175      +/-   ##
========================================
- Coverage   88.89%    87%   -1.89%     
========================================
  Files         244    244              
  Lines        4411   4533     +122     
========================================
+ Hits         3921   3944      +23     
- Misses        458    557      +99     
  Partials       32     32
Impacted Files Coverage Δ
connection/websocket/web_socket.go 10.69% <0%> (+1.77%) ⬆️
realtime/join.go 78.37% <0%> (+5.4%) ⬆️
realtime/subscribe.go 77.14% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5abb8f...047d6b0. Read the comment docs.

@scottinet scottinet merged commit c8b5a76 into 1.x Jul 10, 2018
@scottinet scottinet deleted the embed-so-in-jar branch July 10, 2018 15:22
@jenow jenow mentioned this pull request Sep 10, 2018
@jenow jenow mentioned this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants