Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Document controller for Android SDK #184

Merged
merged 24 commits into from
Aug 1, 2018
Merged

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Aug 1, 2018

What does this PR do ?

Wrap Document controller method for Android SDK in order to take and return JSONObject type when needed

How should this be manually tested?

run docker run --rm -it -v "$(pwd)":/go/src/github.com/kuzzleio/sdk-go android-x86 /build.sh
Use internal/wrappers/build/android/app/build/outputs/aar/app-release.aar in an android project and see if you have JSONObject type on the Document controller's methods

@jenow jenow self-assigned this Aug 1, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.x@351e679). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             1.x     #184   +/-   ##
======================================
  Coverage       ?   88.98%           
======================================
  Files          ?      244           
  Lines          ?     4413           
  Branches       ?        0           
======================================
  Hits           ?     3927           
  Misses         ?      454           
  Partials       ?       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351e679...40af319. Read the comment docs.

Copy link
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to trust you (almost) blindly on that one 😲 👍

@jenow
Copy link
Contributor Author

jenow commented Aug 1, 2018

Well to shortly explain:

  • I put the methods which should take or/and return a JSONObject instead of a String to private access
  • I create new methods of the same name on public but this time with JSONObject parameter or/and return value instead of String
  • Call the previously changed private method by instanciating a JSONObject from the String inside the newly created public methods

That's all :)

edit: Oh and of course I thought of adding the throws JSONException to the new methods signature

@jenow jenow merged commit e0ff871 into 1.x Aug 1, 2018
@jenow jenow deleted the KZL-227-android-wrap-document branch August 1, 2018 14:32
@jenow jenow mentioned this pull request Sep 10, 2018
@jenow jenow mentioned this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants