-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap Document controller for Android SDK #184
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.x #184 +/- ##
======================================
Coverage ? 88.98%
======================================
Files ? 244
Lines ? 4413
Branches ? 0
======================================
Hits ? 3927
Misses ? 454
Partials ? 32 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to trust you (almost) blindly on that one 😲 👍
Well to shortly explain:
That's all :) edit: Oh and of course I thought of adding the throws JSONException to the new methods signature |
What does this PR do ?
Wrap Document controller method for Android SDK in order to take and return JSONObject type when needed
How should this be manually tested?
run docker run --rm -it -v "$(pwd)":/go/src/github.com/kuzzleio/sdk-go android-x86 /build.sh
Use internal/wrappers/build/android/app/build/outputs/aar/app-release.aar in an android project and see if you have JSONObject type on the Document controller's methods