Wrap Collection controller for Android SDK #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenow
changed the title
Codecov Report
@@ Coverage Diff @@
## 1.x #188 +/- ##
=======================================
Coverage 88.98% 88.98%
=======================================
Files 244 244
Lines 4413 4413
=======================================
Hits 3927 3927
Misses 454 454
Partials 32 32Continue to review full report at Codecov.
|
scottinet
approved these changes
Aug 2, 2018
alexandrebouthinon
approved these changes
Aug 2, 2018
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Wrap Collection controller method for Android SDK in order to take and return JSONObject type when needed
How should this be manually tested?
run docker run --rm -it -v "$(pwd)":/go/src/github.com/kuzzleio/sdk-go android-x86 /build.sh
Use internal/wrappers/build/android/app/build/outputs/aar/app-release.aar in an android project and see if you have JSONObject type on the Collection controller's methods