Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove listener when NetworkError is catched #251

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Aug 7, 2019

What does this PR do?

Remove listener on NetworkError once we catched it before reconnecting, otherwise we will write in it but nothing will be listening to it and this will block the whole process of Connect

@jenow jenow self-assigned this Aug 7, 2019
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #251 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   88.91%   88.85%   -0.07%     
==========================================
  Files         244      244              
  Lines        4466     4467       +1     
==========================================
- Hits         3971     3969       -2     
- Misses        441      444       +3     
  Partials       54       54
Impacted Files Coverage Δ
kuzzle/kuzzle.go 27.65% <0%> (-0.2%) ⬇️
realtime/subscribe.go 70.58% <0%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df484a7...529b4a1. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #251 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   88.91%   88.87%   -0.05%     
==========================================
  Files         244      244              
  Lines        4466     4466              
==========================================
- Hits         3971     3969       -2     
- Misses        441      443       +2     
  Partials       54       54
Impacted Files Coverage Δ
kuzzle/kuzzle.go 27.85% <0%> (ø) ⬆️
realtime/subscribe.go 70.58% <0%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df484a7...529b4a1. Read the comment docs.

@jenow jenow merged commit 90f2ca1 into master Aug 7, 2019
@jenow jenow deleted the fix-remove-listener branch October 26, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants