Migrate the collection controller #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3-dev #275 +/- ##
==========================================
+ Coverage 89.71% 89.74% +0.02%
==========================================
Files 241 242 +1
Lines 4034 4045 +11
==========================================
+ Hits 3619 3630 +11
Misses 365 365
Partials 50 50
Continue to review full report at Codecov.
|
jenow
approved these changes
Dec 2, 2020
scottinet
changed the title
Aschen
approved these changes
Dec 9, 2020
collection/delete.go
Outdated
Comment on lines
23
to
29
| if index == "" { | ||
| return types.NewError("Collection.Delete: index required", 400) | ||
| } | ||
|
|
||
| if collection == "" { | ||
| return types.NewError("Collection.Delete: collection required", 400) | ||
| } |
There was a problem hiding this comment.
You should let Kuzzle handle the errors if an index or collection name is empty
Suggested change
| if index == "" { | |
| return types.NewError("Collection.Delete: index required", 400) | |
| } | |
| if collection == "" { | |
| return types.NewError("Collection.Delete: collection required", 400) | |
| } |
There was a problem hiding this comment.
All the other controller actions have this kind of double check on input args. I think we should create an issue for those changes. What do you think @Aschen?
There was a problem hiding this comment.
Yes we should remove every double check from the Go SDK 👍
Aschen
approved these changes
Jan 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adapt the collection controller to be compliant with Kuzzle V2
collection:deletecollection:refresh(added earlier in Fix CI, travis version, documentation version and snippets on 3-dev #274)collection:validateSpecificationsremove deprecated testscollection:updateSpecificationsremove deprecated testscollection:getMappingremove deprecated testsindex:refreshwithcollection:refresh(done earlier in Fix CI, travis version, documentation version and snippets on 3-dev #274)