Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Aug 25, 2021

What does this PR do ?

The options.default option of document.upsert method was wrong: instead of default, the defaults property was sent to Kuzzle

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #660 (31f5354) into 7-dev (1900bf0) will increase coverage by 0.25%.
The diff coverage is 91.66%.

❗ Current head 31f5354 differs from pull request most recent head 7831dd6. Consider uploading reports for the commit 7831dd6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            7-dev     #660      +/-   ##
==========================================
+ Coverage   85.68%   85.94%   +0.25%     
==========================================
  Files          36       36              
  Lines        1712     1715       +3     
  Branches      311      314       +3     
==========================================
+ Hits         1467     1474       +7     
+ Misses        183      179       -4     
  Partials       62       62              
Impacted Files Coverage Δ
src/controllers/Document.ts 69.00% <ø> (+3.00%) ⬆️
src/protocols/Http.ts 84.00% <91.66%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1900bf0...7831dd6. Read the comment docs.

@Aschen Aschen merged commit 1fb22d4 into 7-dev Sep 6, 2021
@Aschen Aschen deleted the fix-upsert-default branch September 6, 2021 15:38
@Aschen Aschen mentioned this pull request Sep 6, 2021
Aschen added a commit that referenced this pull request Sep 7, 2021
# [7.7.5](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.7.5) (2021-09-06)


#### Bug fixes

- [ [#660](#660) ] Fix upsert options.default    ([Aschen](https://github.com/Aschen))

#### Enhancements

- [ [#661](#661) ] Allows to define custom headers for HTTP protocol   ([Aschen](https://github.com/Aschen))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants