Added buttons to select display type #5
Conversation
| <div class="tile is-parent"> | ||
| <article class="tile is-child"> | ||
| <label>Display Settings</label> | ||
| <div class="tabs is-toggle"> |
There was a problem hiding this comment.
Maybe this would be better stylistically as a bulma select?
There was a problem hiding this comment.
I tried this and I think it looks better as a toggle switch actually, but you are welcome to switch it to the select if you think it is better
There was a problem hiding this comment.
Okay, let's keep it as a toggle switch for now.
src/main/kotlin/venus/glue/Driver.kt
Outdated
| @@ -155,4 +155,8 @@ import kotlin.browser.window | |||
| } | |||
| Renderer.updateRegister(id, sim.getReg(id)) | |||
| } | |||
|
|
|||
| @JsName("setDisplay") fun render_setDisplay(dis_type: String) { | |||
There was a problem hiding this comment.
Change this to camelCase? Also maybe a better name would be setRegisterDisplay.
| @@ -166,7 +168,17 @@ internal object Renderer { | |||
| */ | |||
| fun updateRegister(id: Int, value: Int, setActive: Boolean = false) { | |||
| val register = getElement("reg-$id-val") as HTMLInputElement | |||
| register.value = toHex(value) | |||
| var shown_val: String | |||
There was a problem hiding this comment.
Kotlin supports the when block, so this could be more cleanly written as:
register.value = when (displayType) {
"hex" -> toHex(value)
"dec" -> value.toString()
"unsign" -> toUnsigned(value)
else -> toHex(value)
}
| private fun optSetVisibily(opt: String) { | ||
| var tabDisplay: HTMLElement? | ||
| for (option in opts) { | ||
| if (opt.equals(option)) { |
There was a problem hiding this comment.
You don't need .equals for strings in Kotlin, just == is good. (If you need Object.equals from Java, that's ===.)
| var tabDisplay: HTMLElement? | ||
| for (option in opts) { | ||
| if (opt.equals(option)) { | ||
| tabDisplay = document.getElementById("$option-opt") as HTMLElement |
There was a problem hiding this comment.
Move this line out of the if statement?
| for (option in opts) { | ||
| if (opt.equals(option)) { | ||
| tabDisplay = document.getElementById("$option-opt") as HTMLElement | ||
| tabDisplay.className = "is-active" |
There was a problem hiding this comment.
We could make this a single line using the if statement:
tabDisplay.className = if (opt == option) "is-active" else ""
|
All great changes. Most of the caused by teaching myself Kotlin as I write it 😂 |
|
The ASCII renders a little weird, but that does make sense since most of ASCII is not human readable. Would like to add ASCII/Hex support at some point similar to MARS, but this should be good for now. |
|
Thanks for this! I'll take a look when I have the time. |
|
Okay, so I've made some changes:
I will probably reconsider some of this when I eventually update the memory display. Let me know if you have any suggestions! |
Added buttons to the bottom of the simulator screen that allows the user to choose how the values in registers are displayed (either hex, unsigned decimal, or decimal). This is very nice for debugging.
Currently does not support ASCII or changing the memory's display. These two features to come