[TransferEngine] Implement Linux Shared Memory Transport #issue48 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkylarKBKB
changed the title
SkylarKBKB
changed the title
SkylarKBKB
changed the title
|
|
|
Sorry, I modified the shm_transport_test.cpp during debugging. I reassigned the metadata_server for debugging purposes, and now I need to delete line 66: metadata_server = '127.0.0.1:2379'. |
doujiang24
reviewed
Jan 13, 2025
| @@ -62,13 +62,15 @@ class TCPTransportTest : public ::testing::Test { | |||
| metadata_server = env; | |||
| else | |||
| metadata_server = metadata_server; | |||
|
|
|||
| metadata_server = "127.0.0.1:2379"; | |||
There was a problem hiding this comment.
No need hard code here, use the MC_METADATA_SERVER env instead.
| LOG(INFO) << "metadata_server: " << metadata_server; | ||
|
|
||
| env = std::getenv("MC_LOCAL_SERVER_NAME"); | ||
| if (env) | ||
| local_server_name = env; | ||
| else | ||
| local_server_name = "127.0.0.2:12345"; | ||
| local_server_name = "127.0.0.1:2222"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.