feat(store): add client heartbeat support for non ha mode #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extends client functionality to handle master reconnection and segment remounting in non-HA mode, adds corresponding test infrastructure, and improves utility functions for HTTP operations and port allocation. Signed-off-by: xiaguan <751080330@qq.com>
xiaguan
force-pushed
the
move_ping_for_no_ha
branch
from
1c9259c to
3767304
Compare
ykwd
reviewed
Sep 17, 2025
Collaborator
ykwd
left a comment
ykwd
left a comment
There was a problem hiding this comment.
Great work. The code looks good to me. Let me update the corresponding docs before merging.
ykwd
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends client functionality to handle master reconnection and segment remounting in non-HA mode, adds corresponding test infrastructure, and improves utility functions for HTTP operations and port allocation.
By the way, we should also re-insert
TransferEngine Metadatasince HTTP metadata is now embedded in the master.If we don't, other clients won't be able to access it, which could lead to transfer failures and make recovery impossible.
Maybe we can extend the segment definition to include metadata from TransferEngine — but that can be handled in a follow-up PR.