-
Notifications
You must be signed in to change notification settings - Fork 418
[DOC] Update fig #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update fig #987
Conversation
Summary of ChangesHello @stmatengss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how an image is displayed within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates an image in the README.md file, likely to control its display width. While the change achieves this, the new HTML <img> tag has some syntax issues. I've suggested quoting the attribute values and adding an alt attribute for accessibility, which was present in the original markdown image tag.
|
|
||
|  | ||
| <!--  --> | ||
| <img src=image/components.png width=74% /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better HTML syntax and accessibility, it's recommended to quote attribute values and include an alt attribute. The alt attribute provides alternative text for an image if the user for some reason cannot view it (because of slow connection, an error in the src attribute, or if the user uses a screen reader). The original markdown  used components as the alt text.
| <img src=image/components.png width=74% /> | |
| <img src="image/components.png" alt="components" width="74%" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC: @UNIDY2002 Check whether the EP part is correct.
|
Perhaps it is better to change "Mooncake EP" to "Mooncake Backend" in the figure. Mooncake Backend heavily depends on the transfer engine. |
How about "Mooncake EP Backend"? |
I think it is good. |



No description provided.