refactor(store): store remove transfer engine internal api usage

[xiaguan]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @xiaguan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the store module by simplifying the usage of the transfer engine's internal API. It removes explicit Transport:: namespace qualifications from several types and constants related to transfer requests and segment handling, making the code cleaner and potentially reducing dependencies. This change primarily focuses on improving code readability and maintainability within the TransferSubmitter class by directly referencing these types.

Highlights

• API Simplification: The Transport:: namespace qualification has been removed from TransferRequest, SegmentHandle, and INVALID_BATCH_ID types and constants, streamlining their usage within the TransferSubmitter class.
• Header Clean-up: Unnecessary #include "transport/transport.h" directives have been removed from mooncake-store/include/transfer_task.h and mooncake-store/src/client.cpp, reducing compilation dependencies.
• Direct Type Access: The changes imply that TransferRequest and SegmentHandle are now directly available or aliased within the relevant scope, reducing verbosity and improving code readability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors the mooncake-store component to remove direct dependencies on the internal APIs of the transfer engine, specifically by eliminating the usage of types from transport/transport.h. This is a good change that improves modularity and reduces coupling between components. The changes are clean and consistent with the goal of the refactoring. I have a couple of suggestions regarding the use of a magic number that was introduced as part of this change, which would improve code maintainability.

[gemini-code-assist]

Using the magic number UINT64_MAX harms readability and maintainability. Since Transport::INVALID_BATCH_ID is no longer accessible, please define a new constant for this value, for example constexpr BatchID kInvalidBatchId = UINT64_MAX; at an appropriate scope, and use it here and on line 537. This will make the code's intent clearer.

[gemini-code-assist]

As per my comment on line 520, this magic number UINT64_MAX should also be replaced with a named constant for better readability and maintainability.

[alogfans]

LGTM