-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't include excluded properties #169
don't include excluded properties #169
Conversation
In a nutshell, this makes items in |
Thanks for the PR. Before merging this needs tests |
@kvesteri @fuhrysteve I can confirm that this fixes #152 (an issue I spent several hours debugging today).. I'll look into providing a test to get this ready to merge later on tonight. |
@fpruitt that would be awesome! Sorry I haven't circled back to write tests myself |
a8efbce
to
f1d2788
Compare
@kvesteri added some tests! |
Until this is merged, my company is installing from this commit (in case there is a delay getting this merged) |
9b19b21
to
d540483
Compare
fc7d6c0
to
a9ac2fb
Compare
Removed the commit where I tried (and failed) to fix some weirdness with the build failing due to a problem w/ mysql on travisci - it appears to be fixed upstream now. Additionally, I added python 3.6 (and removed 3.3) from the build and @kvesteri - let me know if there's anything else I can do to polish this up - Thanks! |
Please merge this, thank you. |
Thanks for the PR! 🚋 |
Hi @kvesteri! I think this should fix #152 - it seems to for me. Wondering if you could take a look?