fix for unit_of_work.py:263: SAWarning: implicitly coercing SELECT object to scalar subquery #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject to scalar subquery Tested by running `DB=sqlite py.test tests`. With master: 653 passed, 99 skipped, 4909 warnings in 65.90s (0:01:05) With this change: 653 passed, 99 skipped, 4695 warnings in 64.93s (0:01:04)
|
Thanks for this! |
|
@marksteward We are facing this issue in our codebase, we see that this has not been published on PyPi, is there any ETA when this will be published |
|
@indiVar0508 there are a lot of warnings associated with the upgrade to SQLAlchemy 1.4, but they are just warnings, and don't affect functionality. I'm not going to issue a release every time one is fixed. There are a couple more PRs that fix some of the most frequent warnings, and I was planning to cut a release after they're merged, but I don't know when that will be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by running
DB=sqlite py.test testswithpip install SQLAlchemy==1.4.31With master: 653 passed, 99 skipped, 4909 warnings in 65.90s (0:01:05)
With this change: 653 passed, 99 skipped, 4695 warnings in 64.93s (0:01:04)
and then again with
pip install SQLAlchemy==1.3.24655 passed, 97 skipped, 657 warnings in 64.88s (0:01:04)