Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional dependency Colour causes implicit conflict with colour-science #636

Closed
JayPalm opened this issue Sep 12, 2022 · 0 comments · Fixed by #637
Closed

Optional dependency Colour causes implicit conflict with colour-science #636

JayPalm opened this issue Sep 12, 2022 · 0 comments · Fixed by #637
Assignees
@kurtmckee
Labels
bug

Comments

@JayPalm
Copy link
Contributor

JayPalm commented Sep 12, 2022

A trivial example to reproduce:

python3 -m venv venv
source venv/bin/activate
pip install colour-science sqlalchemy-utils
python
>>> import sqlalchemy_utils

Since this is now an optional dependency, it seems like an additional except to catch AttributeError could be added to sqlalchemy_utils.types.color to fix this case.
JayPalm added a commit to JayPalm/sqlalchemy-utils that referenced this issue Sep 12, 2022
@JayPalm
Update color.py for colour-science compatibility
a11723b 
This will allow SQLAlchemy-Utils to be compatible with `colour-science`
Currently, this import makes this package incompatible with `colour-science` due to conflicting `colour` namespace. Since the `colour` package is already optional, this will allow `sqlalchemy-utils` to be used with `colour-science` without conflict.
see [here](kvesteri#636) for the associated issue.
@JayPalm JayPalm mentioned this issue Sep 12, 2022
Merged
@kurtmckee kurtmckee self-assigned this Sep 12, 2022
@kurtmckee kurtmckee added the bug label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kurtmckee kurtmckee

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update color.py for colour-science compatibility JayPalm/sqlalchemy-utils
2 participants
@kurtmckee @JayPalm