fix running error for Spark 3.2.0 and 3.2.1 #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could we have a solution without specifying the spark minor version? |
…of HashAggregateExec.copy
XorSum
force-pushed
the
spark.version-3.2.0
branch
from
3998e9f to
4b27d5c
Compare
XorSum
changed the title
Yes, I have updated this pr according to #601 (comment) . |
|
@XorSum, could you add test case for this compatibility bugfix? |
i advise we add a CI workflow to check whether the modified code works on all minor versions. but currently the CI workflow is running too slow. we should fix it in another issue. |
richox
approved these changes
Oct 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #601
What changes are included in this PR?
Are there any user-facing changes?
No