Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be using
createServerAdapter
adapter to convert to express-compatible handler. Based on this issue conversation: #246 (comment)Description
v5 changes created regression in the way
express
handledrouter.handle
. The right way is anyway to usecreateServerAdapter
(from@whatwg-node/server
) to make itty's router express-compatible.Related Issue
Link to the related issue: #246 (comment)
Type of Change (select one and follow subtasks)