kwild: failBuild was no-op if error was nil (#892)

kwilteam · Jul 18, 2024 · 096043f · 096043f
1 parent ce85f23
commit 096043f
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/cmd/kwild/server/build.go b/cmd/kwild/server/build.go
@@ -922,12 +922,17 @@ func (pe panicErr) Unwrap() error {
 }
 
 func failBuild(err error, msg string) {
-	if err != nil {
+	if err == nil {
 		panic(panicErr{
-			err: err,
-			msg: fmt.Sprintf("%s: %s", msg, err),
+			err: errors.New(msg),
+			msg: msg,
 		})
 	}
+
+	panic(panicErr{
+		err: err,
+		msg: fmt.Sprintf("%s: %s", msg, err),
+	})
 }
 
 func buildListenerManager(d *coreDependencies, ev *voting.EventStore, node *cometbft.CometBftNode, txapp *txapp.TxApp, db sql.ReadTxMaker) *listeners.ListenerManager {